Issue 804733002: Deprecate Window.webkitURL

Issue 804733002: Deprecate Window.webkitURL (Closed)

Created:
6 years ago by philipj_slow

Modified:
3 years, 3 months ago

Reviewers:
sof

CC:
blink-reviews, arv+blink, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Deprecate Window.webkitURL Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/EsJE9wb321I/zzW9Zr3D1xYJ BUG=330691, 348985 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187252

Patch Set 2 : update expectations #

Patch Set 4 : webit => webkit #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
M	LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/domurl/check-instanceof-domurl-functions-expected.txt	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/fast/js/global-constructors-expected.txt	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	LayoutTests/webexposed/global-interface-listing-expected.txt	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/frame/Window.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 12 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

https://codereview.chromium.org/804733002/diff/40001/Source/core/frame/UseCounter.cpp File Source/core/frame/UseCounter.cpp (right): https://codereview.chromium.org/804733002/diff/40001/Source/core/frame/UseCounter.cpp#newcode832 Source/core/frame/UseCounter.cpp:832: return replacedBy("webitURL", "URL"); webit => webkit.

6 years ago (2014-12-16 10:36:09 UTC) #5

philipj_slow

Well that may just have been the highest typo:line ratio I've produced :) https://codereview.chromium.org/804733002/diff/40001/Source/core/frame/UseCounter.cpp File ...

6 years ago (2014-12-16 12:00:45 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804733002/60001

6 years ago (2014-12-16 12:26:22 UTC) #10

commit-bot: I haz the power

Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=187252

6 years ago (2014-12-16 14:13:43 UTC) #11

rkoti302

3 years, 3 months ago (2017-09-21 08:14:11 UTC) #12

Message was sent while issue was closed.

On 2014/12/16 11:59:31, philipj_slow wrote:
> webit => webkit

how can i create console warning message with webkiturl

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages