Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 804713006: Remove exorbitant duplication of DebuggerHasBreakpoints. (Closed)

Created:
5 years, 11 months ago by Michael Starzinger
Modified:
5 years, 11 months ago
Reviewers:
titzer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove exorbitant duplication of DebuggerHasBreakpoints. R=yangguo@chromium.org Committed: https://crrev.com/0ef9ce4ad8024adef4eddac3419c141666cd0be1 Cr-Commit-Position: refs/heads/master@{#26145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M src/compiler.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/isolate-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime-profiler.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 11 months ago (2015-01-19 16:03:16 UTC) #1
titzer
What does LGTM mean in this context....oh the humanity
5 years, 11 months ago (2015-01-19 16:13:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804713006/1
5 years, 11 months ago (2015-01-19 16:24:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-19 16:51:48 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 16:52:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ef9ce4ad8024adef4eddac3419c141666cd0be1
Cr-Commit-Position: refs/heads/master@{#26145}

Powered by Google App Engine
This is Rietveld 408576698