Issue 804693002: Add fake implementation of Surfaces service for sky tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 804693002: Add fake implementation of Surfaces service for sky tests (Closed)

Created:
6 years ago by jamesr

Modified:
6 years ago

Reviewers:
ojan

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -3 lines)			Patch
M	services/BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	services/fake_surfaces/BUILD.gn	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
A	services/fake_surfaces/fake_surfaces_service_application.h	View		1 chunk	+43 lines, -0 lines	0 comments	Download
A	services/fake_surfaces/fake_surfaces_service_application.cc	View	1	1 chunk	+114 lines, -0 lines	0 comments	Download
M	sky/tests/resources/mocha.sky	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/tools/webkitpy/layout_tests/port/base.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

jamesr

This adds an implementation that simply immediately ACKs frames and returns resources.

6 years ago (2014-12-13 01:50:26 UTC) #2

jamesr

6 years ago (2014-12-15 20:16:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6b42a94ef5b80b85eed9d61a3343d8843b752c6c (presubmit successful).