Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 804673002: app_shell: Extend identity API stub (Closed)

Created:
6 years ago by James Cook
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unlimited-storage
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

app_shell: Extend identity API stub Provide stubs for chrome.identity.removeCachedAuthToken() and chrome.identity. onSignInChanged. BUG=441976 TEST=added to app_shell_unittests Committed: https://crrev.com/e6324c7578dba3cf4c19bd74a82598c6f22cdb95 Cr-Commit-Position: refs/heads/master@{#308421}

Patch Set 1 #

Patch Set 2 : (identity-stub) test #

Patch Set 3 : (identity-stub) comments #

Patch Set 4 : (identity-stub) rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M extensions/shell/browser/api/identity/identity_api.h View 1 chunk +17 lines, -0 lines 0 comments Download
M extensions/shell/browser/api/identity/identity_api.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M extensions/shell/browser/api/identity/identity_api_unittest.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M extensions/shell/common/api/identity.idl View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
James Cook
Ken, PTAL. With this patch and the unlimitedStorage one the app loads properly.
6 years ago (2014-12-13 01:06:13 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years ago (2014-12-15 17:33:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804673002/60001
6 years ago (2014-12-15 17:44:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/18412)
6 years ago (2014-12-15 19:32:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804673002/60001
6 years ago (2014-12-15 20:43:34 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-15 21:25:25 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-15 21:26:06 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e6324c7578dba3cf4c19bd74a82598c6f22cdb95
Cr-Commit-Position: refs/heads/master@{#308421}

Powered by Google App Engine
This is Rietveld 408576698