Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 804643002: Enable USB gadget tests on OS X. (Closed)

Created:
6 years ago by Reilly Grant (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable USB gadget tests on OS X. This change fixes the USB device handle tests on OS X by claiming the necessary interfaces before using them and using the right endpoint numbers. It also enables the HID connection tests on OS X by creating a MessageLoopForUI on the main thread (to mimic the usual configuration in the Chrome browser process) and a separate thread running a MessageLoopForIO. Committed: https://crrev.com/67650d64ea56326fef63e5d9812b6fd2590a2a25 Cr-Commit-Position: refs/heads/master@{#308210}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -26 lines) Patch
M device/hid/hid_connection_unittest.cc View 3 chunks +31 lines, -5 lines 0 comments Download
M device/test/usb_test_gadget.h View 1 chunk +1 line, -1 line 0 comments Download
M device/test/usb_test_gadget_impl.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M device/usb/usb_device_handle_unittest.cc View 4 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Reilly Grant (use Gerrit)
Ken, please take a look. I'm working on getting this working on Windows too but ...
6 years ago (2014-12-13 00:04:29 UTC) #4
Ken Rockot(use gerrit already)
lgtm
6 years ago (2014-12-13 00:23:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804643002/40001
6 years ago (2014-12-13 00:37:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
6 years ago (2014-12-13 01:19:00 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-13 01:19:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67650d64ea56326fef63e5d9812b6fd2590a2a25
Cr-Commit-Position: refs/heads/master@{#308210}

Powered by Google App Engine
This is Rietveld 408576698