experimental/PdfViewer/inc/SkPdfDiffEncoder.h - Issue 80463005: Separate and update PDF_DIFF_TRACE_IN_PNG

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: experimental/PdfViewer/inc/SkPdfDiffEncoder.h

Issue 80463005: Separate and update PDF_DIFF_TRACE_IN_PNG (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « experimental/PdfViewer/SkPdfConfig.h ('k') | experimental/PdfViewer/inc/SkPdfTokenLooper.h » ('j') | experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2013 Google Inc.

	3 *

	4 * Use of this source code is governed by a BSD-style license that can be

	5 * found in the LICENSE file.

	6 */

	7

	8 #ifndef SkPdfDiffEncoder_DEFINED

	9 #define SkPdfDiffEncoder_DEFINED

	10

	11 struct PdfToken;

	12

	13 class SkPdfDiffEncoder {

	14 public:

	15 // If PDF_TRACE_DIFF_IN_PNG is defined, the difference created by

	16 // using this token is written to a file named

	17 // "/tmp/log_step_by_step/step-%i-%s.png". Otherwise this function does

	18 // nothing.

	19 // TODO(scroggo): Pass SkPdfContext and SkCanvas for info.

	20 static void WriteToFile(PdfToken*);
	mtklein 2013/11/22 14:46:12 Do you anticipate this class will become more than Do you anticipate this class will become more than just a function? If not, or at least not for now, I'd just change this to namespace SkPdfDiffEncoder { void WriteToFile(PdfToken); } to make it clear SkPdfDiffEncoder is a namespace. I don't think the callers would have to change at all. scroggo* 2013/11/22 15:47:16 reed@ encouraged me to use a class in another inst Show quoted text On 2013/11/22 14:46:12, mtklein wrote: > Do you anticipate this class will become more than just a function? > > If not, or at least not for now, I'd just change this to > > namespace SkPdfDiffEncoder { > void WriteToFile(PdfToken*); > } > > to make it clear SkPdfDiffEncoder is a namespace. I don't think the callers > would have to change at all. reed@ encouraged me to use a class in another instance for consistency- see (https://codereview.chromium.org/25581002/diff/1/include/utils/SkFrontBuffered...). As discussed in person, I think we're content to do either one.
	21 };

	22

	23 #endif // SkPdfDiffEncoder_DEFINED

OLD	NEW