Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: src/heap/store-buffer.cc

Issue 804603006: Regularly check hash set addresses to verify memory integrity. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/store-buffer.cc
diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc
index aac68116ce840f3ca72715c41aaa3809ac028173..d126551242634f855fbebd723fad2f53aed5dc69 100644
--- a/src/heap/store-buffer.cc
+++ b/src/heap/store-buffer.cc
@@ -81,6 +81,9 @@ void StoreBuffer::SetUp() {
hash_sets_are_empty_ = false;
ClearFilteringHashSets();
+
+ heap_->isolate()->set_store_buffer_hash_set_1_address(hash_set_1_);
+ heap_->isolate()->set_store_buffer_hash_set_2_address(hash_set_2_);
}
@@ -554,6 +557,9 @@ void StoreBuffer::IteratePointersToNewSpace(ObjectSlotCallback slot_callback,
void StoreBuffer::Compact() {
+ CHECK(hash_set_1_ == heap_->isolate()->store_buffer_hash_set_1_address());
+ CHECK(hash_set_2_ == heap_->isolate()->store_buffer_hash_set_2_address());
+
Address* top = reinterpret_cast<Address*>(heap_->store_buffer_top());
if (top == start_) return;
« no previous file with comments | « no previous file | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698