minidump/test/minidump_string_writer_test_util.cc - Issue 804593002: Move string16 and char16 in to base::

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/test/minidump_string_writer_test_util.cc

Issue 804593002: Move string16 and char16 in to base:: (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: include roll of mini_chromium to 37bac7... Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: minidump/test/minidump_string_writer_test_util.cc

diff --git a/minidump/test/minidump_string_writer_test_util.cc b/minidump/test/minidump_string_writer_test_util.cc

index 7a485df52478a601ea8c1883f19ab62088b18b4c..6f5ff6b991ae43a6a9c6770d08be1f626dcec678 100644

--- a/minidump/test/minidump_string_writer_test_util.cc

+++ b/minidump/test/minidump_string_writer_test_util.cc

@@ -89,10 +89,10 @@ const MinidumpUTF8String* MinidumpUTF8StringAtRVA(

return TMinidumpStringAtRVA<MinidumpUTF8String>(file_contents, rva);

}

-string16 MinidumpStringAtRVAAsString(const std::string& file_contents,

- RVA rva) {

- return TMinidumpStringAtRVAAsString<string16, MINIDUMP_STRING>(file_contents,

- rva);

+base::string16 MinidumpStringAtRVAAsString(const std::string& file_contents,

+ RVA rva) {

+ return TMinidumpStringAtRVAAsString<base::string16, MINIDUMP_STRING>(

+ file_contents, rva);

}

std::string MinidumpUTF8StringAtRVAAsString(const std::string& file_contents,