Issue 804563002: Revert "Revert "Add image_diff from the chromium repo.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 804563002: Revert "Revert "Add image_diff from the chromium repo."" (Closed)

Created:
6 years ago by ojan

Modified:
6 years ago

Reviewers:

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert "Revert "Add image_diff from the chromium repo."" This reverts commit 79d76b3da8f72ca3affaaaf2821b1d0bb212f522. The BUILD.gn file needed a dep to //build/config/sanitizers:deps in order to link under the asan build. TBR=blundell@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/077293f62a41c879644cd94ce62e832db69de7e0

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+689 lines, -350 lines)			Patch
M	sky/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/tools/imagediff/BUILD.gn	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	sky/tools/imagediff/image_diff.cc	View	1 chunk	+449 lines, -0 lines	0 comments	Download
A	sky/tools/imagediff/image_diff_png.h	View	1 chunk	+35 lines, -0 lines	0 comments	Download
A +	sky/tools/imagediff/image_diff_png.cc	View	19 chunks	+183 lines, -350 lines	0 comments	Download

Total messages: 1 (0 generated)

ojan

6 years ago (2014-12-12 17:48:51 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
077293f62a41c879644cd94ce62e832db69de7e0 (presubmit successful).