Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Unified Diff: Source/modules/permissions/Permissions.cpp

Issue 804553003: Implement Permissions.query() and static PermissionStatus. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: stupid compilers Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/permissions/Permissions.cpp
diff --git a/Source/modules/permissions/Permissions.cpp b/Source/modules/permissions/Permissions.cpp
index cd5771c131025dad4981beed50033b314516c32b..bcbe773606fd9fbefc114b8c4dd98bfe057dd6cf 100644
--- a/Source/modules/permissions/Permissions.cpp
+++ b/Source/modules/permissions/Permissions.cpp
@@ -6,24 +6,67 @@
#include "modules/permissions/Permissions.h"
#include "bindings/core/v8/ScriptPromise.h"
+#include "bindings/core/v8/ScriptPromiseResolver.h"
#include "core/dom/DOMException.h"
+#include "core/dom/Document.h"
#include "core/dom/ExceptionCode.h"
+#include "modules/permissions/PermissionController.h"
+#include "modules/permissions/PermissionQueryCallback.h"
+#include "public/platform/Platform.h"
+#include "public/platform/modules/permissions/WebPermissionClient.h"
namespace blink {
-Permissions::~Permissions()
+namespace {
+
+WebPermissionClient* permissionClient(ExecutionContext* executionContext)
{
+ if (executionContext->isDocument()) {
+ Document* document = toDocument(executionContext);
+ if (!document->frame())
+ return nullptr;
+ PermissionController* controller = PermissionController::from(*document->frame());
+ return controller ? controller->client() : nullptr;
+ }
+ return Platform::current()->permissionClient();
}
-DEFINE_TRACE(Permissions)
+} // anonymous namespace
+
+Permissions::~Permissions()
{
}
// static
ScriptPromise Permissions::query(ScriptState* scriptState, const AtomicString& permissionName)
{
- // FIXME: implement.
- return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError, "Feature not yet supported."));
+ WebPermissionClient* client = permissionClient(scriptState->executionContext());
+ if (!client)
+ return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "In its current state, the global scope can't query permissions."));
+
+ WebPermissionType type;
+ if (permissionName == "geolocation") {
+ type = WebPermissionTypeGeolocation;
+ } else if (permissionName == "notifications") {
+ type = WebPermissionTypeNotifications;
+ } else if (permissionName == "push-notifications") {
+ type = WebPermissionTypePushNotifications;
+ } else if (permissionName == "midi-sysex") {
+ type = WebPermissionTypeMidiSysEx;
+ } else {
+ ASSERT_NOT_REACHED();
+ type = WebPermissionTypeGeolocation;
+ }
+
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromise promise = resolver->promise();
+
+ client->queryPermission(type, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionQueryCallback(resolver, type));
jochen (gone - plz use gerrit) 2015/03/10 13:16:42 what happens if you use the permission API on file
mlamouri (slow - plz ping) 2015/03/11 10:56:57 Good point. I would not say that it does not work
+ return promise;
+}
+
+DEFINE_TRACE(Permissions)
+{
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698