Implement Permissions.query() and static PermissionStatus.

Implement Permissions.query() and static PermissionStatus.

This is adding a WebPermissionClient implement by WebFrameClient
and blink::Platform in order to be accessible from Workers and
Documents.

BUG=437770
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191721

[mlamouri (slow - plz ping), 2014-12-15 12:46:45]

mlamouri@chromium.org changed reviewers:
+ mkwst@chromium.org

[mlamouri (slow - plz ping), 2014-12-15 12:46:45]

mlamouri@chromium.org changed required reviewers:
+ mkwst@chromium.org

[mlamouri (slow - plz ping), 2014-12-15 12:46:45]

Mike, can you take a look at this as WIP. It might require some cleanups.

[mlamouri (slow - plz ping), 2015-03-06 11:53:48]

Mike, PTAL

https://codereview.chromium.org/804553003/diff/80001/Source/modules/permissio...
File Source/modules/permissions/PermissionStatus.h (right):

https://codereview.chromium.org/804553003/diff/80001/Source/modules/permissio...
Source/modules/permissions/PermissionStatus.h:40: // TODO: needs to be used by
the IDL
That thing is temporary because otherwise, this CL isn't really using m_type and
the compiler is complaining about it. The PermissionQueryCallback and
PermissionStatus will need that so better to pass it now instead of rewriting
most of the plumbing later.

[mlamouri (slow - plz ping), 2015-03-10 09:53:21]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org

[mlamouri (slow - plz ping), 2015-03-10 09:53:22]

+jochen@ because mkwst@ is marked as OOO.

[jochen (gone - plz use gerrit), 2015-03-10 13:16:43]

some comments

https://codereview.chromium.org/804553003/diff/120001/Source/modules/permissi...
File Source/modules/permissions/PermissionStatus.cpp (right):

https://codereview.chromium.org/804553003/diff/120001/Source/modules/permissi...
Source/modules/permissions/PermissionStatus.cpp:25: delete status;
just delete status, it can cope with nullptr

https://codereview.chromium.org/804553003/diff/120001/Source/modules/permissi...
File Source/modules/permissions/Permissions.cpp (right):

https://codereview.chromium.org/804553003/diff/120001/Source/modules/permissi...
Source/modules/permissions/Permissions.cpp:64: client->queryPermission(type,
KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new
PermissionQueryCallback(resolver, type));
what happens if you use the permission API on file:// scheme? it just won't
work?

https://codereview.chromium.org/804553003/diff/120001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/804553003/diff/120001/public/platform/Platfor...
public/platform/Platform.h:665: virtual WebPermissionClient* permissionClient()
{ return 0; }
that's the permissionClient used for all workers, right?

https://codereview.chromium.org/804553003/diff/120001/public/platform/modules...
File public/platform/modules/permissions/WebPermissionStatus.h (right):

https://codereview.chromium.org/804553003/diff/120001/public/platform/modules...
public/platform/modules/permissions/WebPermissionStatus.h:13:
WebPermissionStatusPrompt,
add WebPermissionStatusLast?

https://codereview.chromium.org/804553003/diff/120001/public/platform/modules...
File public/platform/modules/permissions/WebPermissionType.h (right):

https://codereview.chromium.org/804553003/diff/120001/public/platform/modules...
public/platform/modules/permissions/WebPermissionType.h:14:
WebPermissionTypeMidiSysEx,
...Last

[mlamouri (slow - plz ping), 2015-03-11 10:56:55]

mlamouri@chromium.org changed required reviewers:
- mkwst@chromium.org

[mlamouri (slow - plz ping), 2015-03-11 10:56:57]

https://codereview.chromium.org/804553003/diff/120001/Source/modules/permissi...
File Source/modules/permissions/PermissionStatus.cpp (right):

https://codereview.chromium.org/804553003/diff/120001/Source/modules/permissi...
Source/modules/permissions/PermissionStatus.cpp:25: delete status;
On 2015/03/10 at 13:16:42, jochen (slow) wrote:
> just delete status, it can cope with nullptr

Done.

https://codereview.chromium.org/804553003/diff/120001/Source/modules/permissi...
File Source/modules/permissions/Permissions.cpp (right):

https://codereview.chromium.org/804553003/diff/120001/Source/modules/permissi...
Source/modules/permissions/Permissions.cpp:64: client->queryPermission(type,
KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new
PermissionQueryCallback(resolver, type));
On 2015/03/10 at 13:16:42, jochen (slow) wrote:
> what happens if you use the permission API on file:// scheme? it just won't
work?

Good point. I would not say that it does not work though. It toString() will
return "null" or "file://". "null" would probably not work well but "file://"
would work if one API was to save permissions for files.

This said, geolocation, notifications and push do not work on file scheme. I'm
not sure about other APIs related to this API. In the long term, I would like to
not pass the security origin but instead have the browser process find the
origin of the frame using the RFH - I did not investigate that yet but it seems
that it would be better than trusting the renderer process.

I've added a comment.

https://codereview.chromium.org/804553003/diff/120001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/804553003/diff/120001/public/platform/Platfor...
public/platform/Platform.h:665: virtual WebPermissionClient* permissionClient()
{ return 0; }
On 2015/03/10 at 13:16:42, jochen (slow) wrote:
> that's the permissionClient used for all workers, right?

Yes. I agree it's not idea but I don't want that feature to be blocked on the
discussion I started in blink-dev. I will update the modules that need updating
when we reach a conclusion. (What' I'm doing is the way other modules are doing
things, like PushProvider).

https://codereview.chromium.org/804553003/diff/120001/public/platform/modules...
File public/platform/modules/permissions/WebPermissionStatus.h (right):

https://codereview.chromium.org/804553003/diff/120001/public/platform/modules...
public/platform/modules/permissions/WebPermissionStatus.h:13:
WebPermissionStatusPrompt,
On 2015/03/10 at 13:16:42, jochen (slow) wrote:
> add WebPermissionStatusLast?

I don't think it's needed. I'm not sending that via IPC. The renderer process is
using Mojo's PermissionStatus.

https://codereview.chromium.org/804553003/diff/120001/public/platform/modules...
File public/platform/modules/permissions/WebPermissionType.h (right):

https://codereview.chromium.org/804553003/diff/120001/public/platform/modules...
public/platform/modules/permissions/WebPermissionType.h:14:
WebPermissionTypeMidiSysEx,
On 2015/03/10 at 13:16:43, jochen (slow) wrote:
> ...Last

Ditto.

[mlamouri (slow - plz ping), 2015-03-11 10:59:37]

Review comments applied. PTAL.

[jochen (gone - plz use gerrit), 2015-03-11 16:05:23]

lgtm

[mlamouri (slow - plz ping), 2015-03-11 16:08:19]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-03-11 16:08:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/804553003/140001

[commit-bot: I haz the power, 2015-03-11 17:55:05]

Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191721