base/task/cancelable_task_tracker_unittest.cc - Issue 804533005: Standardize usage of virtual/override/final specifiers in base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task/cancelable_task_tracker_unittest.cc

Issue 804533005: Standardize usage of virtual/override/final specifiers in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/system_monitor/system_monitor_unittest.cc ('K') | « base/system_monitor/system_monitor_unittest.cc ('k') | base/threading/sequenced_worker_pool_unittest.cc » ('j') | base/threading/sequenced_worker_pool_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/task/cancelable_task_tracker_unittest.cc

diff --git a/base/task/cancelable_task_tracker_unittest.cc b/base/task/cancelable_task_tracker_unittest.cc

index e122e8deef082f77a261835166cb6dbdf176c4be..a5ccc8455ad251a8ffda6b0b3b27efd36f65dacb 100644

--- a/base/task/cancelable_task_tracker_unittest.cc

+++ b/base/task/cancelable_task_tracker_unittest.cc

@@ -25,7 +25,7 @@ namespace {

class CancelableTaskTrackerTest : public testing::Test {

protected:

- virtual ~CancelableTaskTrackerTest() { RunCurrentLoopUntilIdle(); }

+ ~CancelableTaskTrackerTest() override { RunCurrentLoopUntilIdle(); }

void RunCurrentLoopUntilIdle() {

RunLoop run_loop;

@@ -347,7 +347,7 @@ class CancelableTaskTrackerDeathTest : public CancelableTaskTrackerTest {

::testing::FLAGS_gtest_death_test_style = "threadsafe";

}

- virtual ~CancelableTaskTrackerDeathTest() {}

+ ~CancelableTaskTrackerDeathTest() override {}

Nico 2014/12/22 22:05:42 remove?

dcheng 2014/12/22 22:41:26 Done.

};

// Duplicated from base/threading/thread_checker.h so that we can be