base/files/file_path_unittest.cc - Issue 804533005: Standardize usage of virtual/override/final specifiers in base/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_path_unittest.cc

Issue 804533005: Standardize usage of virtual/override/final specifiers in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/files/file_path_unittest.cc

diff --git a/base/files/file_path_unittest.cc b/base/files/file_path_unittest.cc

index 956faea32186e7cd9cdfbc5b69056d93fe15e0d5..559037bdf1923083ac172cb7d2e4f6875d87ff95 100644

--- a/base/files/file_path_unittest.cc

+++ b/base/files/file_path_unittest.cc

@@ -50,12 +50,8 @@ struct UTF8TestData {

// to be a PlatformTest

class FilePathTest : public PlatformTest {

protected:

- virtual void SetUp() override {

- PlatformTest::SetUp();

- }

- virtual void TearDown() override {

- PlatformTest::TearDown();

- }

+ void SetUp() override { PlatformTest::SetUp(); }

Nico 2014/12/22 22:05:42 This doesn't have any effect. Can FilePathTest jus

+ void TearDown() override { PlatformTest::TearDown(); }

};

TEST_F(FilePathTest, DirName) {

« no previous file with comments | « base/debug/trace_event_unittest.cc ('k') | base/files/file_path_watcher_browsertest.cc » ('j') | base/sequence_checker_unittest.cc » ('J')