Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: base/prefs/scoped_user_pref_update_unittest.cc

Issue 804533005: Standardize usage of virtual/override/final specifiers in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/prefs/pref_value_store_unittest.cc ('k') | base/process/memory_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/mock_pref_change_callback.h" 5 #include "base/prefs/mock_pref_change_callback.h"
6 #include "base/prefs/pref_change_registrar.h" 6 #include "base/prefs/pref_change_registrar.h"
7 #include "base/prefs/pref_registry_simple.h" 7 #include "base/prefs/pref_registry_simple.h"
8 #include "base/prefs/scoped_user_pref_update.h" 8 #include "base/prefs/scoped_user_pref_update.h"
9 #include "base/prefs/testing_pref_service.h" 9 #include "base/prefs/testing_pref_service.h"
10 #include "testing/gmock/include/gmock/gmock.h" 10 #include "testing/gmock/include/gmock/gmock.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 using testing::_; 13 using testing::_;
14 using testing::Mock; 14 using testing::Mock;
15 15
16 class ScopedUserPrefUpdateTest : public testing::Test { 16 class ScopedUserPrefUpdateTest : public testing::Test {
17 public: 17 public:
18 ScopedUserPrefUpdateTest() : observer_(&prefs_) {} 18 ScopedUserPrefUpdateTest() : observer_(&prefs_) {}
19 virtual ~ScopedUserPrefUpdateTest() {} 19 ~ScopedUserPrefUpdateTest() override {}
20 20
21 protected: 21 protected:
22 virtual void SetUp() { 22 void SetUp() override {
23 prefs_.registry()->RegisterDictionaryPref(kPref); 23 prefs_.registry()->RegisterDictionaryPref(kPref);
24 registrar_.Init(&prefs_); 24 registrar_.Init(&prefs_);
25 registrar_.Add(kPref, observer_.GetCallback()); 25 registrar_.Add(kPref, observer_.GetCallback());
26 } 26 }
27 27
28 static const char kPref[]; 28 static const char kPref[];
29 static const char kKey[]; 29 static const char kKey[];
30 static const char kValue[]; 30 static const char kValue[];
31 31
32 TestingPrefServiceSimple prefs_; 32 TestingPrefServiceSimple prefs_;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 TEST_F(ScopedUserPrefUpdateTest, NeverTouchAnything) { 72 TEST_F(ScopedUserPrefUpdateTest, NeverTouchAnything) {
73 const base::DictionaryValue* old_value = prefs_.GetDictionary(kPref); 73 const base::DictionaryValue* old_value = prefs_.GetDictionary(kPref);
74 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0); 74 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
75 { 75 {
76 DictionaryPrefUpdate update(&prefs_, kPref); 76 DictionaryPrefUpdate update(&prefs_, kPref);
77 } 77 }
78 const base::DictionaryValue* new_value = prefs_.GetDictionary(kPref); 78 const base::DictionaryValue* new_value = prefs_.GetDictionary(kPref);
79 EXPECT_EQ(old_value, new_value); 79 EXPECT_EQ(old_value, new_value);
80 Mock::VerifyAndClearExpectations(&observer_); 80 Mock::VerifyAndClearExpectations(&observer_);
81 } 81 }
OLDNEW
« no previous file with comments | « base/prefs/pref_value_store_unittest.cc ('k') | base/process/memory_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698