Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: base/sequence_checker_unittest.cc

Issue 804533005: Standardize usage of virtual/override/final specifiers in base/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/bind.h" 6 #include "base/bind.h"
7 #include "base/bind_helpers.h" 7 #include "base/bind_helpers.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 private: 49 private:
50 SequenceChecker sequence_checker_; 50 SequenceChecker sequence_checker_;
51 51
52 DISALLOW_COPY_AND_ASSIGN(SequenceCheckedObject); 52 DISALLOW_COPY_AND_ASSIGN(SequenceCheckedObject);
53 }; 53 };
54 54
55 class SequenceCheckerTest : public testing::Test { 55 class SequenceCheckerTest : public testing::Test {
56 public: 56 public:
57 SequenceCheckerTest() : other_thread_("sequence_checker_test_other_thread") {} 57 SequenceCheckerTest() : other_thread_("sequence_checker_test_other_thread") {}
58 58
59 virtual ~SequenceCheckerTest() {} 59 ~SequenceCheckerTest() override {}
Nico 2014/12/22 22:05:42 remove?
dcheng 2014/12/22 22:41:26 Done.
60 60
61 virtual void SetUp() override { 61 void SetUp() override {
62 other_thread_.Start(); 62 other_thread_.Start();
63 ResetPool(); 63 ResetPool();
64 } 64 }
65 65
66 virtual void TearDown() override { 66 void TearDown() override {
67 other_thread_.Stop(); 67 other_thread_.Stop();
68 pool()->Shutdown(); 68 pool()->Shutdown();
69 } 69 }
70 70
71 protected: 71 protected:
72 base::Thread* other_thread() { return &other_thread_; } 72 base::Thread* other_thread() { return &other_thread_; }
73 73
74 const scoped_refptr<SequencedWorkerPool>& pool() { 74 const scoped_refptr<SequencedWorkerPool>& pool() {
75 return pool_owner_->pool(); 75 return pool_owner_->pool();
76 } 76 }
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 #endif // ENABLE_SEQUENCE_CHECKER 327 #endif // ENABLE_SEQUENCE_CHECKER
328 328
329 #endif // GTEST_HAS_DEATH_TEST || !ENABLE_SEQUENCE_CHECKER 329 #endif // GTEST_HAS_DEATH_TEST || !ENABLE_SEQUENCE_CHECKER
330 330
331 } // namespace 331 } // namespace
332 332
333 } // namespace base 333 } // namespace base
334 334
335 // Just in case we ever get lumped together with other compilation units. 335 // Just in case we ever get lumped together with other compilation units.
336 #undef ENABLE_SEQUENCE_CHECKER 336 #undef ENABLE_SEQUENCE_CHECKER
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698