Issue 804473005: Pass gyp_source_dir to generate_tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 804473005: Pass gyp_source_dir to generate_tool. (Closed)

Created:
6 years ago by scroggo

Modified:
6 years ago

Reviewers:
borenet

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@debugging

Project:
skia

Visibility:
Public.

Pass gyp_source_dir to generate_tool. When generating the tool makefiles, which also calls android_framework_gyp, we also need to pass the gyp directory. TBR=borenet NOTRY=True NOTREECHECKS=True BUG=skia:3233 Committed: https://skia.googlesource.com/skia/+/09acfc8d1fd1723d01b7103f58a6f1502648f428

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	platform_tools/android/bin/gyp_to_android.py	View		3 chunks	+6 lines, -3 lines	0 comments	Download
	M	platform_tools/android/gyp_gen/tool_makefile_writer.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804473005/1

6 years ago (2014-12-12 16:58:09 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-12 17:02:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/09acfc8d1fd1723d01b7103f58a6f1502648f428