Issue 804463003: Fix build after previous commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 804463003: Fix build after previous commit. (Closed)

Created:
6 years ago by jam

Modified:
6 years ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix build after previous commit. TBR=tsepez Committed: https://pdfium.googlesource.com/pdfium/+/f6505100fc132ef866adaf3ff1fb7f06d0ca7a9b

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+237 lines, -140 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	core/src/fxge/ge/fx_ge_linux.cpp	View	1 chunk	+234 lines, -0 lines	1 comment	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/bigint/BigInteger.cc	View	8 chunks	+0 lines, -34 lines	0 comments	Download
M	third_party/bigint/BigInteger.hh	View	4 chunks	+0 lines, -16 lines	0 comments	Download
M	third_party/bigint/BigIntegerUtils.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	third_party/bigint/BigUnsigned.cc	View	6 chunks	+0 lines, -27 lines	0 comments	Download
M	third_party/bigint/BigUnsigned.hh	View	7 chunks	+0 lines, -31 lines	0 comments	Download
M	third_party/bigint/BigUnsignedInABase.cc	View	4 chunks	+0 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jam

https://codereview.chromium.org/804463003/diff/1/core/src/fxge/ge/fx_ge_linux.cpp File core/src/fxge/ge/fx_ge_linux.cpp (right): https://codereview.chromium.org/804463003/diff/1/core/src/fxge/ge/fx_ge_linux.cpp#newcode10 core/src/fxge/ge/fx_ge_linux.cpp:10: #if _FXM_PLATFORM_ == _FXM_PLATFORM_LINUX_ i misread the ifdef before ...

6 years ago (2014-12-13 01:45:13 UTC) #2

jam

6 years ago (2014-12-13 01:48:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f6505100fc132ef866adaf3ff1fb7f06d0ca7a9b.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages