src/scopes.cc - Issue 804463002: Stack-allocate block variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scopes.cc

Issue 804463002: Stack-allocate block variables (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: moar progress Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scopes.cc

diff --git a/src/scopes.cc b/src/scopes.cc

index 39b67a886444fe1db46a54e4006d37abd68d447a..d4006f33437999d5befe34d51d1e146442ae357c 100644

--- a/src/scopes.cc

+++ b/src/scopes.cc

@@ -1241,7 +1241,7 @@ bool Scope::MustAllocateInContext(Variable* var) {

if (has_forced_context_allocation()) return true;

if (var->mode() == TEMPORARY) return false;

if (var->mode() == INTERNAL) return true;

- if (is_catch_scope() || is_block_scope() || is_module_scope()) return true;

+ if (is_catch_scope() || is_module_scope()) return true;

if (is_script_scope() && IsLexicalVariableMode(var->mode())) return true;

return var->has_forced_context_allocation() ||

scope_calls_eval_ ||

« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | no next file » | no next file with comments »