components/autofill/content/renderer/form_cache.h - Issue 804443002: Autofill: Modify various utility function to deal with unowned form fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/form_cache.h

Issue 804443002: Autofill: Modify various utility function to deal with unowned form fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge UnownedFormElementsAndFieldSetsToFormData call into FindFormAndFieldForFormControlElement Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/form_autofill_util.cc ('K') | « components/autofill/content/renderer/form_autofill_util.cc ('k') | components/autofill/content/renderer/form_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/form_cache.h

diff --git a/components/autofill/content/renderer/form_cache.h b/components/autofill/content/renderer/form_cache.h

index e659492b2e86cd55d7038e36f1f3cfc87e3f7b40..be6b5dd9c98a1cbeb20c3d9576f5e58c586ca14a 100644

--- a/components/autofill/content/renderer/form_cache.h

+++ b/components/autofill/content/renderer/form_cache.h

@@ -32,15 +32,6 @@ class FormCache {

FormCache();

~FormCache();

- // Get all form control elements from |elements| that are not part of a form.

- // If |fieldsets| is not NULL, also append the fieldsets encountered that are

- // not part of a form.

- // Exposed for sharing with tests.

- static std::vector<blink::WebFormControlElement>

- GetUnownedAutofillableFormFieldElements(

- const blink::WebElementCollection& elements,

- std::vector<blink::WebElement>* fieldsets);

// Scans the DOM in |frame| extracting and storing forms that have not been

// seen before. Returns the extracted forms.

std::vector<FormData> ExtractNewForms(const blink::WebFrame& frame);