Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 804423002: MIPS: ES6 computed property names

Created:
6 years ago by balazs.kilvady
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

MIPS: ES6 computed property names Port a235b1076ae4b79baae1d17a5079cb6cfc462ba3 Original commit message: This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, a76419f0f497db156eb1010e9b4be398951280cb with no changes. I cannot reproduce the issue on Win8.1 or WinXP. Letting the bots try again. BUG=v8:3754 LOG=Y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -16 lines) Patch
M src/mips/full-codegen-mips.cc View 5 chunks +69 lines, -8 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 5 chunks +69 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
balazs.kilvady
6 years ago (2014-12-16 17:59:53 UTC) #2
arv (Not doing code reviews)
Please wait a little bit since I'm still not sure this will stick this time. ...
6 years ago (2014-12-16 18:05:12 UTC) #3
balazs.kilvady
On 2014/12/16 18:05:12, arv wrote: > Please wait a little bit since I'm still not ...
6 years ago (2014-12-16 18:07:54 UTC) #4
paul.l...
LGTM, once arv gives the ok to land it.
6 years ago (2014-12-16 18:23:45 UTC) #5
arv (Not doing code reviews)
6 years ago (2014-12-16 19:38:47 UTC) #6
I had to revert so this patch will have to wait until I figure this out for
realz.

Powered by Google App Engine
This is Rietveld 408576698