Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Issue 8044036: Merge 95124 - Address lifetime issues in OfflineAudioDestinationNode (take 2) (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
===================================================================
--- Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp (revision 96035)
+++ Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp (working copy)
@@ -43,6 +43,7 @@
OfflineAudioDestinationNode::OfflineAudioDestinationNode(AudioContext* context, AudioBuffer* renderTarget)
: AudioDestinationNode(context, renderTarget->sampleRate())
, m_renderTarget(renderTarget)
+ , m_renderThread(0)
, m_startedRendering(false)
{
m_renderBus = adoptPtr(new AudioBus(renderTarget->numberOfChannels(), renderQuantumSize));
@@ -52,9 +53,6 @@
OfflineAudioDestinationNode::~OfflineAudioDestinationNode()
{
- if (m_renderThread)
- waitForThreadCompletion(m_renderThread, 0);
-
uninitialize();
}
@@ -83,6 +81,7 @@
if (!m_startedRendering) {
m_startedRendering = true;
+ ref(); // See corresponding deref() call in notifyCompleteDispatch().
m_renderThread = createThread(OfflineAudioDestinationNode::renderEntry, this, "offline renderer");
}
}
@@ -146,8 +145,6 @@
}
// Our work is done. Let the AudioContext know.
- // See corresponding deref() call in notifyCompleteDispatch().
- ref();
callOnMainThread(notifyCompleteDispatch, this);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698