Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp

Issue 8044035: Merge 94984 - Address lifetime issues in OfflineAudioDestinationNode (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
===================================================================
--- Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp (revision 96034)
+++ Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp (working copy)
@@ -52,6 +52,9 @@
OfflineAudioDestinationNode::~OfflineAudioDestinationNode()
{
+ if (m_renderThread)
+ waitForThreadCompletion(m_renderThread, 0);
+
uninitialize();
}
@@ -143,6 +146,8 @@
}
// Our work is done. Let the AudioContext know.
+ // See corresponding deref() call in notifyCompleteDispatch().
+ ref();
callOnMainThread(notifyCompleteDispatch, this);
}
@@ -154,6 +159,7 @@
return;
destinationNode->notifyComplete();
+ destinationNode->deref();
}
void OfflineAudioDestinationNode::notifyComplete()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698