Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: Source/WebCore/dom/Document.cpp

Issue 8044027: Merge 95959 - Delete retired custom font data only on document (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/text/custom-font-data-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/dom/Document.cpp
===================================================================
--- Source/WebCore/dom/Document.cpp (revision 95970)
+++ Source/WebCore/dom/Document.cpp (working copy)
@@ -1564,8 +1564,14 @@
element->recalcStyle(change);
}
+ // FIXME: Disabling the deletion of retired custom font data until
+ // we fix all the stale style bugs (68804, 68624, etc). These bugs
+ // indicate problems where some styles were not updated in recalcStyle,
+ // thereby retaining stale copy of font data. To prevent that, we
+ // disable this code for now and only delete retired custom font data
+ // in Document destructor.
// Now that all RenderStyles that pointed to retired fonts have been updated, the fonts can safely be deleted.
- deleteRetiredCustomFonts();
+ // deleteRetiredCustomFonts();
#if USE(ACCELERATED_COMPOSITING)
if (view()) {
« no previous file with comments | « LayoutTests/fast/text/custom-font-data-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698