Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: Source/core/rendering/RenderTable.cpp

Issue 804383002: Layout captions in simplifiedNormalFlowLayout for tables. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/table/display-table-caption-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderTable.cpp
diff --git a/Source/core/rendering/RenderTable.cpp b/Source/core/rendering/RenderTable.cpp
index 81d33641eeeffb0f9723f0eb3509c4dbc3457edd..55ac926b320090b88b536fdf717ceab19a8df9c2 100644
--- a/Source/core/rendering/RenderTable.cpp
+++ b/Source/core/rendering/RenderTable.cpp
@@ -387,6 +387,11 @@ void RenderTable::distributeExtraLogicalHeight(int extraLogicalHeight)
void RenderTable::simplifiedNormalFlowLayout()
{
+ // FIXME: We should walk through the items in the tree in tree order to do the layout here
+ // instead of walking through individual parts of the tree. crbug.com/442737
+ for (auto& caption : m_captions)
+ caption->layoutIfNeeded();
+
for (RenderTableSection* section = topSection(); section; section = sectionBelow(section)) {
section->layoutIfNeeded();
section->computeOverflowFromCells();
« no previous file with comments | « LayoutTests/fast/table/display-table-caption-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698