LayoutTests/fast/table/caption-position.html - Issue 804383002: Layout captions in simplifiedNormalFlowLayout for tables.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/caption-position.html

Issue 804383002: Layout captions in simplifiedNormalFlowLayout for tables. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/run-after-display.js"></script>

	3

	4 Test passes is above is on top.

	5 <table cellspacing="0" cellpadding="0">

	6 <caption>

	7 <div style="position:relative; height:2em;">

	8 <div id="elm" style="position:absolute; left:0;">above</div>

	9 </div>

	10 </caption>

	11 <tr>

	12 <td>below</td>

	13 </tr>

	14 </table>

	15

	16 <script>

	17 if (window.testRunner)

	18 testRunner.waitUntilDone();

	19

	20 runAfterDisplay(function() {
	mstensho (USE GERRIT) 2014/12/17 20:36:01 Instead of using the runAfterDisplay() machinery, Instead of using the runAfterDisplay() machinery, couldn't you just do an onload = function() { document.body.offsetTop; /* force layout / document.getElementById('elm').style.left = '1px'; } ? You'd get rid of the notifyDone() thing as well then. dsinclair* 2014/12/17 20:44:08 I thought I'd tried that, but apparently not. Done Show quoted text On 2014/12/17 20:36:01, mstensho wrote: > Instead of using the runAfterDisplay() machinery, couldn't you just do an onload > = function() { document.body.offsetTop; /* force layout */ > document.getElementById('elm').style.left = '1px'; } ? > > You'd get rid of the notifyDone() thing as well then. I thought I'd tried that, but apparently not. Done.
	21 document.getElementById('elm').style.left = '1px';

	22 if (testRunner)

	23 testRunner.notifyDone();

	24 });

	25 </script>

OLD	NEW