Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 804363002: Improve Chrome OS VPN API documentation (Closed)

Created:
6 years ago by bartfab (slow)
Modified:
5 years, 11 months ago
Reviewers:
mkearney1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@managed_cros
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve Chrome OS VPN API documentation Clarify that packets originating on Chrome OS are intercepted by the API, not packets reaching the device from outside. BUG=407541 Committed: https://crrev.com/b75aff40c818606e554617fb8323b4a696e3e899 Cr-Commit-Position: refs/heads/master@{#311509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/docs/templates/intros/vpnProvider.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bartfab (slow)
Hi Margaret, Could you take a look please?
6 years ago (2014-12-16 14:02:54 UTC) #2
bartfab (slow)
On 2014/12/16 14:02:54, bartfab wrote: > Hi Margaret, > > Could you take a look ...
5 years, 11 months ago (2015-01-08 17:10:08 UTC) #3
mkearney1
lgtm
5 years, 11 months ago (2015-01-14 17:15:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804363002/1
5 years, 11 months ago (2015-01-14 17:16:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 18:06:37 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:09:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b75aff40c818606e554617fb8323b4a696e3e899
Cr-Commit-Position: refs/heads/master@{#311509}

Powered by Google App Engine
This is Rietveld 408576698