Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 804343007: Make RenderBox::scrollToOffset check for overflow (Closed)

Created:
6 years ago by ajuma
Modified:
6 years ago
Reviewers:
Ian Vollick, skobes
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make RenderBox::scrollToOffset check for overflow This makes RenderBox::scrollToOffset check for overflow before trying to scroll, making its behavior consistent with other RenderBox scroll methods. BUG=443479 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187486

Patch Set 1 #

Patch Set 2 : Add missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
A LayoutTests/fast/scroll-behavior/scroll-element-without-overflow.html View 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/fast/scroll-behavior/scroll-element-without-overflow-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ajuma
Callers to RenderBox::scrollToOffset added in http://crrev.com/782793002 don't check for overflow. An alternative fix would be ...
6 years ago (2014-12-18 18:31:43 UTC) #3
skobes
lgtm
6 years ago (2014-12-18 18:44:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804343007/20001
6 years ago (2014-12-18 18:46:04 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-18 19:46:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187486

Powered by Google App Engine
This is Rietveld 408576698