Issue 804343006: Version 3.30.33.10 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 804343006: Version 3.30.33.10 (cherry-pick) (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)

Modified:
6 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@3.30

Target Ref:
refs/pending/branch-heads/3.30

Project:
v8

Visibility:
Public.

Version 3.30.33.10 (cherry-pick) Merged cfccf397d00b6fa94206d2cf89dd73efa995199a v8::String::Concat must not throw. BUG=chromium:420240 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=4dececfea12f0b1fed5ceadcc34e9ffc609dda9c

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -8 lines)			Patch
M	src/api.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	4 chunks	+25 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

6 years ago (2014-12-18 13:07:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4dececfea12f0b1fed5ceadcc34e9ffc609dda9c.