Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 804333005: Revert of [turbofan] Fix bunch of tests failing with --turbo-deoptimization. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Fix bunch of tests failing with --turbo-deoptimization. (patchset #1 id:1 of https://codereview.chromium.org/786333004/) Reason for revert: This changes layout test expectations. I ran a bisect over the layout tests: Bad: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/1600 Good: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2032/builds/1599 If this is intentional please first land a CL with manualrebaseline test expectations for the changed tests and then reland. Original issue's description: > [turbofan] Fix bunch of tests failing with --turbo-deoptimization. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/e9e772121b36697821dbfff61f36e0a68367f21c > Cr-Commit-Position: refs/heads/master@{#26115} TBR=bmeurer@chromium.org,jarin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d962c092f30642bcff30dc32744715b8d0987fdd Cr-Commit-Position: refs/heads/master@{#26119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -55 lines) Patch
M src/compiler/linkage.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +40 lines, -50 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [turbofan] Fix bunch of tests failing with --turbo-deoptimization.
5 years, 11 months ago (2015-01-17 13:36:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804333005/1
5 years, 11 months ago (2015-01-17 13:45:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-17 13:45:36 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-17 13:45:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d962c092f30642bcff30dc32744715b8d0987fdd
Cr-Commit-Position: refs/heads/master@{#26119}

Powered by Google App Engine
This is Rietveld 408576698