Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 804323004: Reland Shrink initial old generation size based on new space survival rate. (Closed)

Created:
6 years ago by Hannes Payer (out of office)
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland Shrink initial old generation size based on new space survival rate. I picked a more conservative start value this time of half max old generation size. BUG= Committed: https://crrev.com/e89318138c11a9fba3ffeaee103506ed5c1f84f6 Cr-Commit-Position: refs/heads/master@{#25890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -5 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/gc-tracer.h View 5 chunks +27 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 4 chunks +31 lines, -0 lines 0 comments Download
M src/heap/heap.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 8 chunks +38 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
6 years ago (2014-12-18 15:54:37 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-18 15:56:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804323004/1
6 years ago (2014-12-18 16:29:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 16:55:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e89318138c11a9fba3ffeaee103506ed5c1f84f6 Cr-Commit-Position: refs/heads/master@{#25890}
6 years ago (2014-12-18 18:05:45 UTC) #7
haraken
5 years, 11 months ago (2015-01-13 08:41:36 UTC) #8
Message was sent while issue was closed.
On 2014/12/18 18:05:45, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/e89318138c11a9fba3ffeaee103506ed5c1f84f6
> Cr-Commit-Position: refs/heads/master@{#25890}

Just FYI, this CL caused OOM in Dromaeo/dom-modify.html in Oilpan release
builds. The OOM happens only in oilpan builds, and I'm investigating why.

Powered by Google App Engine
This is Rietveld 408576698