refactor duplicate code into single visitor

pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.invocation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
+import 'package:analysis_server/src/services/completion/optype_ast_visitor.dart';
 import 'package:analysis_server/src/services/completion/suggestion_builder.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 
 import '../../protocol_server.dart' show CompletionSuggestionKind;
 
 /**
  * A computer for calculating invocation / access suggestions
  * `completion.getSuggestions` request results.
  */
 class InvocationComputer extends DartCompletionComputer {
   SuggestionBuilder builder;
 
   @override
   bool computeFast(DartCompletionRequest request) {
-    builder = request.node.accept(new _InvocationAstVisitor(request));
-    if (builder != null) {
-      return builder.computeFast(request.node);
+
+    // Determine the type of suggestions to be made
+    OpTypeAstVisitor opTypeVisitor = new OpTypeAstVisitor(request.offset);
+    request.node.accept(opTypeVisitor);
+
+    // Build the suggestions
+    if (opTypeVisitor.includeInvocationSuggestions) {
+      builder = request.node.accept(new _InvocationAstVisitor(request));
+      if (builder != null) {
+        return builder.computeFast(request.node);
+      }
     }
+
     return true;
   }
 
   @override
   Future<bool> computeFull(DartCompletionRequest request) {
     if (builder != null) {
       return builder.computeFull(request.node);
     }
     return new Future.value(false);
   }
@@ skipping 36 matching lines @@
  */
 class _InvocationAstVisitor extends GeneralizingAstVisitor<SuggestionBuilder> {
   final DartCompletionRequest request;
 
   _InvocationAstVisitor(this.request);
 
   @override
   visitConstructorName(ConstructorName node) {
     // some PrefixedIdentifier nodes are transformed into
     // ConstructorName nodes during the resolution process.
-    Token period = node.period;
-    if (period != null && request.offset > period.offset) {
-      TypeName type = node.type;
-      if (type != null) {
-        SimpleIdentifier prefix = type.name;
-        if (prefix != null) {
-          return new _PrefixedIdentifierSuggestionBuilder(request);
-        }
-      }
-    }
-    return null;
+    return new _PrefixedIdentifierSuggestionBuilder(request);
   }
 
   @override
   SuggestionBuilder visitMethodInvocation(MethodInvocation node) {
-    Token period = node.period;
-    if (period == null || period.offset < request.offset) {
-      return new _ExpressionSuggestionBuilder(request);
-    }
-    return null;
+    return new _ExpressionSuggestionBuilder(request);
   }
 
   @override
   SuggestionBuilder visitNode(AstNode node) {
     return null;
   }
 
   @override
   SuggestionBuilder visitPrefixedIdentifier(PrefixedIdentifier node) {
     // some PrefixedIdentifier nodes are transformed into
     // ConstructorName nodes during the resolution process.
-    Token period = node.period;
-    if (period != null && request.offset > period.offset) {
-      SimpleIdentifier prefix = node.prefix;
-      if (prefix != null) {
-        return new _PrefixedIdentifierSuggestionBuilder(request);
-      }
-    }
-    return null;
+    return new _PrefixedIdentifierSuggestionBuilder(request);
   }
 
   @override
   SuggestionBuilder visitPropertyAccess(PropertyAccess node) {
-    Token operator = node.operator;
-    if (operator != null && operator.offset < request.offset) {
-      return new _ExpressionSuggestionBuilder(request);
-    }
-    return null;
+    return new _ExpressionSuggestionBuilder(request);
   }
 
   @override
   SuggestionBuilder visitSimpleIdentifier(SimpleIdentifier node) {
     return node.parent.accept(this);
   }
 }
 
 /**
  * An [Element] visitor for determining the appropriate invocation/access
@@ skipping 93 matching lines @@
 
   @override
   Future<bool> visitVariableElement(VariableElement element) {
     DartType type = element.type;
     if (type != null) {
       ClassElementSuggestionBuilder.suggestionsFor(request, type.element);
     }
     return new Future.value(true);
   }
 }