Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 804263005: Removing --assert-test commandline flag (Closed)

Created:
5 years, 11 months ago by anujsharma
Modified:
5 years, 11 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing --assert-test commandline flag BUG=414272 Committed: https://crrev.com/7203639e4ae3c985b01beb07a534f46cd6cef8a0 Cr-Commit-Position: refs/heads/master@{#311405}

Patch Set 1 #

Patch Set 2 : Fixed build errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
anujsharma
sky@chromium.org: Please review changes in chrome/browser avi@chromium.org: Please review changes in content module
5 years, 11 months ago (2015-01-13 09:30:37 UTC) #2
Avi (use Gerrit)
LGTM
5 years, 11 months ago (2015-01-13 15:34:04 UTC) #3
sky
LGTM
5 years, 11 months ago (2015-01-13 18:36:58 UTC) #4
anujsharma
On 2015/01/13 18:36:58, sky wrote: > LGTM
5 years, 11 months ago (2015-01-14 02:50:31 UTC) #6
anujsharma
Thanks Avi and Sky for lgtm.
5 years, 11 months ago (2015-01-14 02:50:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804263005/20001
5 years, 11 months ago (2015-01-14 02:51:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 03:54:23 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 03:55:48 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7203639e4ae3c985b01beb07a534f46cd6cef8a0
Cr-Commit-Position: refs/heads/master@{#311405}

Powered by Google App Engine
This is Rietveld 408576698