Display shared module platforms on about://voicesearch page.

Display shared module platforms on about://voicesearch page.

It's not enough to know what version of the shared module is installed, we
also need to know the language, since the web store splits up crxs by
language/platform tuples. The only way to find out which language is
installed is by looking at what files are available. In our case,
looking at the contents of the _platform_specific directory.

Committed: https://crrev.com/4c559b468d544ddee9f545ad578949ebc02e3919
Cr-Commit-Position: refs/heads/master@{#310161}

[Anand Mistry (off Chromium), 2015-01-05 03:30:44]

amistry@chromium.org changed reviewers:
+ estade@chromium.org, rlp@chromium.org

[rpetterson, 2015-01-05 03:57:30]

overall lgtm with a nit

https://codereview.chromium.org/804193003/diff/1/chrome/browser/ui/webui/voic...
File chrome/browser/ui/webui/voicesearch_ui.cc (right):

https://codereview.chromium.org/804193003/diff/1/chrome/browser/ui/webui/voic...
chrome/browser/ui/webui/voicesearch_ui.cc:114: ASCIIToUTF16("undefined") :
files);
move to the line above or indent

[Anand Mistry (off Chromium), 2015-01-05 04:11:49]

https://codereview.chromium.org/804193003/diff/1/chrome/browser/ui/webui/voic...
File chrome/browser/ui/webui/voicesearch_ui.cc (right):

https://codereview.chromium.org/804193003/diff/1/chrome/browser/ui/webui/voic...
chrome/browser/ui/webui/voicesearch_ui.cc:114: ASCIIToUTF16("undefined") :
files);
On 2015/01/05 03:57:30, rpetterson wrote:
> move to the line above or indent

Done.

[Evan Stade, 2015-01-05 19:13:38]

lgtm with comments addressed

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/voicesearch_ui.cc (right):

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:5: #include
"chrome/browser/ui/webui/voicesearch_ui.h"
the files should be called voice_search_ui.*

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:155: // voiceSearchInfo will take
ownership of |info|, and clean it up on
nit: remove this comment

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:193: if (extension) {
nit: no curlies

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:198: //
AddSharedModulePlatformsOnFileThread.
nit: remove comment

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:209: base::Passed(&list))));
optional nit: I think list.Pass() is more self-documenting

[Anand Mistry (off Chromium), 2015-01-05 23:33:01]

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/voicesearch_ui.cc (right):

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:5: #include
"chrome/browser/ui/webui/voicesearch_ui.h"
On 2015/01/05 19:13:38, Evan Stade wrote:
> the files should be called voice_search_ui.*

That seems orthogonal to this change, and renaming these two files is going to
mess with the git history.

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:155: // voiceSearchInfo will take
ownership of |info|, and clean it up on
On 2015/01/05 19:13:38, Evan Stade wrote:
> nit: remove this comment

Done.

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:193: if (extension) {
On 2015/01/05 19:13:38, Evan Stade wrote:
> nit: no curlies

Done.

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:198: //
AddSharedModulePlatformsOnFileThread.
On 2015/01/05 19:13:38, Evan Stade wrote:
> nit: remove comment

Done.

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:209: base::Passed(&list))));
On 2015/01/05 19:13:38, Evan Stade wrote:
> optional nit: I think list.Pass() is more self-documenting

It fails to compile:

../../base/bind_internal.h:1899:9: error: no matching constructor for
initialization of 'scoped_ptr<base::ListValue,
base::DefaultDeleter<base::ListValue> >'
        p2_(p2) {
        ^   ~~
../../base/bind.h:109:11: note: in instantiation of member function
'base::internal::BindState<base::internal::RunnableAdapter<void ((anonymous
namespace)::VoiceSearchDomHandler::*)(scoped_ptr<base::ListValue,
base::DefaultDeleter<base::ListValue> >)>, void ((anonymous
namespace)::VoiceSearchDomHandler *, scoped_ptr<base::ListValue,
base::DefaultDeleter<base::ListValue> >), void (base::WeakPtr<(anonymous
namespace)::VoiceSearchDomHandler>, scoped_ptr<base::ListValue,
base::DefaultDeleter<base::ListValue> >)>::BindState' requested here
      new BindState(internal::MakeRunnable(functor), args...));
          ^
../../chrome/browser/ui/webui/voicesearch_ui.cc:202:19: note: in instantiation
of function template specialization 'base::Bind<void ((anonymous
namespace)::VoiceSearchDomHandler::*)(scoped_ptr<base::ListValue,
base::DefaultDeleter<base::ListValue> >), base::WeakPtr<(anonymous
namespace)::VoiceSearchDomHandler>, scoped_ptr<base::ListValue,
base::DefaultDeleter<base::ListValue> > >' requested here
            base::Bind(&VoiceSearchDomHandler::ReturnVoiceSearchInfo,

[Evan Stade, 2015-01-06 01:07:19]

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/voicesearch_ui.cc (right):

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:5: #include
"chrome/browser/ui/webui/voicesearch_ui.h"
On 2015/01/05 23:33:01, Anand Mistry wrote:
> On 2015/01/05 19:13:38, Evan Stade wrote:
> > the files should be called voice_search_ui.*
> 
> That seems orthogonal to this change, and renaming these two files is going to
> mess with the git history.

git is smart, especially if you use --follow. I think this request is going to
be orthogonal to basically any change. Now is as good a time as any.

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:209: base::Passed(&list))));
On 2015/01/05 23:33:01, Anand Mistry wrote:
> On 2015/01/05 19:13:38, Evan Stade wrote:
> > optional nit: I think list.Pass() is more self-documenting
> 
> It fails to compile:
> 
> ../../base/bind_internal.h:1899:9: error: no matching constructor for
> initialization of 'scoped_ptr<base::ListValue,
> base::DefaultDeleter<base::ListValue> >'
>         p2_(p2) {
>         ^   ~~
> ../../base/bind.h:109:11: note: in instantiation of member function
> 'base::internal::BindState<base::internal::RunnableAdapter<void ((anonymous
> namespace)::VoiceSearchDomHandler::*)(scoped_ptr<base::ListValue,
> base::DefaultDeleter<base::ListValue> >)>, void ((anonymous
> namespace)::VoiceSearchDomHandler *, scoped_ptr<base::ListValue,
> base::DefaultDeleter<base::ListValue> >), void (base::WeakPtr<(anonymous
> namespace)::VoiceSearchDomHandler>, scoped_ptr<base::ListValue,
> base::DefaultDeleter<base::ListValue> >)>::BindState' requested here
>       new BindState(internal::MakeRunnable(functor), args...));
>           ^
> ../../chrome/browser/ui/webui/voicesearch_ui.cc:202:19: note: in instantiation
> of function template specialization 'base::Bind<void ((anonymous
> namespace)::VoiceSearchDomHandler::*)(scoped_ptr<base::ListValue,
> base::DefaultDeleter<base::ListValue> >), base::WeakPtr<(anonymous
> namespace)::VoiceSearchDomHandler>, scoped_ptr<base::ListValue,
> base::DefaultDeleter<base::ListValue> > >' requested here
>             base::Bind(&VoiceSearchDomHandler::ReturnVoiceSearchInfo,

base::Passed(list.Pass());

[Anand Mistry (off Chromium), 2015-01-06 01:53:33]

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/voicesearch_ui.cc (right):

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:5: #include
"chrome/browser/ui/webui/voicesearch_ui.h"
On 2015/01/06 01:07:19, Evan Stade wrote:
> On 2015/01/05 23:33:01, Anand Mistry wrote:
> > On 2015/01/05 19:13:38, Evan Stade wrote:
> > > the files should be called voice_search_ui.*
> > 
> > That seems orthogonal to this change, and renaming these two files is going
to
> > mess with the git history.
> 
> git is smart, especially if you use --follow. I think this request is going to
> be orthogonal to basically any change. Now is as good a time as any.

Done.

https://codereview.chromium.org/804193003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/voicesearch_ui.cc:209: base::Passed(&list))));
On 2015/01/06 01:07:19, Evan Stade wrote:
> On 2015/01/05 23:33:01, Anand Mistry wrote:
> > On 2015/01/05 19:13:38, Evan Stade wrote:
> > > optional nit: I think list.Pass() is more self-documenting
> > 
> > It fails to compile:
> > 
> > ../../base/bind_internal.h:1899:9: error: no matching constructor for
> > initialization of 'scoped_ptr<base::ListValue,
> > base::DefaultDeleter<base::ListValue> >'
> >         p2_(p2) {
> >         ^   ~~
> > ../../base/bind.h:109:11: note: in instantiation of member function
> > 'base::internal::BindState<base::internal::RunnableAdapter<void ((anonymous
> > namespace)::VoiceSearchDomHandler::*)(scoped_ptr<base::ListValue,
> > base::DefaultDeleter<base::ListValue> >)>, void ((anonymous
> > namespace)::VoiceSearchDomHandler *, scoped_ptr<base::ListValue,
> > base::DefaultDeleter<base::ListValue> >), void (base::WeakPtr<(anonymous
> > namespace)::VoiceSearchDomHandler>, scoped_ptr<base::ListValue,
> > base::DefaultDeleter<base::ListValue> >)>::BindState' requested here
> >       new BindState(internal::MakeRunnable(functor), args...));
> >           ^
> > ../../chrome/browser/ui/webui/voicesearch_ui.cc:202:19: note: in
instantiation
> > of function template specialization 'base::Bind<void ((anonymous
> > namespace)::VoiceSearchDomHandler::*)(scoped_ptr<base::ListValue,
> > base::DefaultDeleter<base::ListValue> >), base::WeakPtr<(anonymous
> > namespace)::VoiceSearchDomHandler>, scoped_ptr<base::ListValue,
> > base::DefaultDeleter<base::ListValue> > >' requested here
> >             base::Bind(&VoiceSearchDomHandler::ReturnVoiceSearchInfo,
> 
> base::Passed(list.Pass());

Done.

[Evan Stade, 2015-01-06 18:30:50]

thanks, lgtm

[Anand Mistry (off Chromium), 2015-01-06 21:51:23]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2015-01-06 21:52:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/804193003/60001

[commit-bot: I haz the power, 2015-01-06 22:42:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-06 22:43:34]

Patchset 4 (id:??) landed as
https://crrev.com/4c559b468d544ddee9f545ad578949ebc02e3919
Cr-Commit-Position: refs/heads/master@{#310161}