Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Unified Diff: Source/modules/serviceworkers/WaitUntilObserver.cpp

Issue 804163002: Revert 186849 "Bind Window focus ability to the ExecutionContext..." (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/2250/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/WaitUntilObserver.cpp
===================================================================
--- Source/modules/serviceworkers/WaitUntilObserver.cpp (revision 187183)
+++ Source/modules/serviceworkers/WaitUntilObserver.cpp (working copy)
@@ -88,16 +88,6 @@
return;
}
- if (!executionContext())
- return;
-
- // When handling a notificationclick event, we want to allow one window to
- // be focused. Regardless of whether one window was focused,
- // |consumeWindowFocus| will be called when all the pending activities will
- // be resolved.
- if (m_type == NotificationClick)
- executionContext()->allowWindowFocus();
-
incrementPendingActivity();
ScriptPromise::cast(scriptState, value).then(
ThenFunction::createFunction(scriptState, this, ThenFunction::Fulfilled),
@@ -144,7 +134,6 @@
break;
case NotificationClick:
client->didHandleNotificationClickEvent(m_eventID, result);
- executionContext()->consumeWindowFocus();
break;
case Push:
client->didHandlePushEvent(m_eventID, result);
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerClient.cpp ('k') | Source/web/WebScopedWindowFocusAllowedIndicator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698