Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 804083004: Revert of DevTools: Parallelize trace messages serialization. (Closed)

Created:
6 years ago by fmeawad
Modified:
6 years ago
CC:
chromium-reviews, wfh+watch_chromium.org, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Parallelize trace messages serialization. (patchset #7 id:140001 of https://codereview.chromium.org/750183008/) Reason for revert: Speculatively reverting this CL as it might be related to redness in the perf bots. The new crashes on the bots all had this CL in their range, and the crashes are all related to MemoryError while receiving trace data. (crbug.com/443398) Feel free to reland if the revert does not fix the issue. Original issue's description: > DevTools: Parallelize trace messages serialization. > > Move serialization into a worker thread. As a result > IO thread will be able to send messages to the browser. > > The original implementation did serialization on IO thread > and was not able to send the messages because ipc had > is_blocked_on_write_ = true and had no chance to check > the actual state of the channel. So the messages were > collected in output_queue. Also the messages could be quite > big and could block the IO thread for a long time. > > BUG= > > Committed: https://crrev.com/d58e06aafd6572e681f9d30f313bf5393db9f2bc > Cr-Commit-Position: refs/heads/master@{#308773} TBR=nduca@chromium.org,pfeldman@chromium.org,caseq@chromium.org,yurys@chromium.org,wangxianzhu@chromium.org,skyostil@google.com,dsinclair@chromium.org,skyostil@chromium.org,loislo@chromium.org NOTREECHECKS=true NOTRY=true BUG=443398 Committed: https://crrev.com/da5a86a1c9d8061eaec825dbd7296a7d608a1eff Cr-Commit-Position: refs/heads/master@{#309257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -33 lines) Patch
M base/debug/trace_event_impl.h View 3 chunks +3 lines, -7 lines 0 comments Download
M base/debug/trace_event_impl.cc View 7 chunks +9 lines, -22 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fmeawad
Created Revert of DevTools: Parallelize trace messages serialization.
6 years ago (2014-12-19 21:01:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804083004/1
6 years ago (2014-12-19 21:02:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 21:03:37 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-19 21:04:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da5a86a1c9d8061eaec825dbd7296a7d608a1eff
Cr-Commit-Position: refs/heads/master@{#309257}

Powered by Google App Engine
This is Rietveld 408576698