Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 804063002: WAE on Macs too. That leaves only Android framework builds. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
bsalomon, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

WAE on Macs too. That leaves only Android framework builds. Will rebase after yours lands. BUG=skia: Committed: https://skia.googlesource.com/skia/+/161b6dee11a67e877ef5b339b17775b8e44c5927 Committed: https://skia.googlesource.com/skia/+/f19ec511b141222c3ee54c9251312fd1ef1eff78

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : brace #

Patch Set 4 : mac a different way #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M gyp/common_variables.gypi View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
mtklein
6 years ago (2014-12-15 17:01:27 UTC) #2
bsalomon
lgtm
6 years ago (2014-12-15 17:07:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804063002/20001
6 years ago (2014-12-15 17:26:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1216) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1181) Build-Mac10.8-Clang-x86_64-Release-Trybot ...
6 years ago (2014-12-15 17:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804063002/40001
6 years ago (2014-12-15 17:35:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1525)
6 years ago (2014-12-15 17:39:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804063002/40001
6 years ago (2014-12-15 17:40:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/161b6dee11a67e877ef5b339b17775b8e44c5927
6 years ago (2014-12-15 17:45:06 UTC) #14
mtklein
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/805043002/ by mtklein@google.com. ...
6 years ago (2014-12-15 17:48:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804063002/60001
6 years ago (2014-12-15 18:30:19 UTC) #17
commit-bot: I haz the power
6 years ago (2014-12-15 18:38:46 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f19ec511b141222c3ee54c9251312fd1ef1eff78

Powered by Google App Engine
This is Rietveld 408576698