Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 804033002: Revert of Migrate device_utils.RestartServer to adb_wrapper (Closed)

Created:
6 years ago by perezju
Modified:
6 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate device_utils.RestartServer to adb_wrapper (patchset #2 id:20001 of https://codereview.chromium.org/724413003/) Reason for revert: Broke (even more!) the android perf bots. Reverting while investigating. Original issue's description: > Migrate device_utils.RestartServer to adb_wrapper > > The implementation is based on the new AdbWrapper class methods: > KillServer and StartServer. > > BUG=267773 > > Committed: https://crrev.com/872e2f0d24529365451323c77fe52a56687b32bf > Cr-Commit-Position: refs/heads/master@{#308336} TBR=jbudorick@chromium.org NOTREECHECKS=true NOTRY=true BUG=267773 Committed: https://crrev.com/72e9ec8981e90a0d75ece2b861520cfbdbbdff7f Cr-Commit-Position: refs/heads/master@{#308355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -48 lines) Patch
M build/android/pylib/device/adb_wrapper.py View 3 chunks +4 lines, -18 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 chunk +1 line, -14 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
perezju
Created Revert of Migrate device_utils.RestartServer to adb_wrapper
6 years ago (2014-12-15 15:38:30 UTC) #1
jbudorick
lgtm
6 years ago (2014-12-15 15:43:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/804033002/1
6 years ago (2014-12-15 15:43:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 15:44:15 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 15:45:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72e9ec8981e90a0d75ece2b861520cfbdbbdff7f
Cr-Commit-Position: refs/heads/master@{#308355}

Powered by Google App Engine
This is Rietveld 408576698