Fully qualify usage of ArraySizeHelper to prevent conflict.

Fully qualify usage of ArraySizeHelper to prevent conflict.

mojo redefines ArraySizeHelper in the mojo namespace. When arraysize is used
in the mojo namespace, with both version in scope, the compiler, on android, is complaining that the reference is
not unique. To prevent this, qualify the usage of ArraySizeHelper in
base/macros.h

Committed: https://crrev.com/6d0be449b4c1c667a44762c9dbd0ee18ea120ade
Cr-Commit-Position: refs/heads/master@{#315290}

[qsr, 2014-12-16 09:30:51]

qsr@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2014-12-16 09:45:35]

Can mojo just change its ArraySizeHelper to MojoArraySizeHelper to workaround
this problem?

[qsr, 2014-12-16 09:47:21]

On 2014/12/16 09:45:35, Lei Zhang wrote:
> Can mojo just change its ArraySizeHelper to MojoArraySizeHelper to workaround
> this problem?

 Probably. But is there any reason not to qualify this? It is not in any
namespace, so it is easy (all things considered) to get a conflict.

[Lei Zhang, 2014-12-16 09:55:35]

On 2014/12/16 09:47:21, qsr wrote:
> On 2014/12/16 09:45:35, Lei Zhang wrote:
> > Can mojo just change its ArraySizeHelper to MojoArraySizeHelper to
workaround
> > this problem?
> 
>  Probably. But is there any reason not to qualify this? It is not in any
> namespace, so it is easy (all things considered) to get a conflict.

Not really other than we've never needed to.

BTW, there's several copies of base/macros.h / ArraySizeHelper floating around
in various third_party repos. If mojo (as is) ever interacts with any of them,
you'll still have a bad time.

[qsr, 2014-12-16 10:01:02]

On 2014/12/16 09:55:35, Lei Zhang wrote:
> On 2014/12/16 09:47:21, qsr wrote:
> > On 2014/12/16 09:45:35, Lei Zhang wrote:
> > > Can mojo just change its ArraySizeHelper to MojoArraySizeHelper to
> workaround
> > > this problem?
> > 
> >  Probably. But is there any reason not to qualify this? It is not in any
> > namespace, so it is easy (all things considered) to get a conflict.
> 
> Not really other than we've never needed to.
> 
> BTW, there's several copies of base/macros.h / ArraySizeHelper floating around
> in various third_party repos. If mojo (as is) ever interacts with any of them,
> you'll still have a bad time.

 Ok, I will modify the mojo one then. Thanks.

[qsr, 2015-02-06 16:30:00]

Re-opened as it was decided that this was the right place to do this.

Lei, can you look at this. Thanks.

[Lei Zhang, 2015-02-06 23:35:41]

lgtm

[qsr, 2015-02-09 10:03:32]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2015-02-09 10:04:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/804023002/20001

[commit-bot: I haz the power, 2015-02-09 12:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-09 12:05:22]

Try jobs failed on following builders:
  ios_rel_device_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[qsr, 2015-02-09 12:24:23]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2015-02-09 12:24:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/804023002/20001

[commit-bot: I haz the power, 2015-02-09 13:52:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-09 13:53:30]

Patchset 2 (id:??) landed as
https://crrev.com/6d0be449b4c1c667a44762c9dbd0ee18ea120ade
Cr-Commit-Position: refs/heads/master@{#315290}