[turbofan] First version of loop analysis: loop finder on the soup of nodes.

src/zone-containers.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_ZONE_CONTAINERS_H_
 #define V8_ZONE_CONTAINERS_H_
 
 #include <deque>
 #include <list>
 #include <queue>
@@ skipping 69 matching lines @@
   // Constructs an empty stack.
   explicit ZoneStack(Zone* zone)
       : std::stack<T, ZoneDeque<T>>(ZoneDeque<T>(zone)) {}
 };
 
 
 // Typedefs to shorten commonly used vectors.
 typedef ZoneVector<bool> BoolVector;
 typedef ZoneVector<int> IntVector;
 
+// A small adapter for iterating over ranges of elements.
+template <typename T>
+struct PtrRange {

[Sven Panne, 2014/12/15 14:21:59]

Drive-by nit-pick: If performance (i.e. the copying of the range) is not an
issue (it's just for test if I see this correctly), this class is unnecessary:
Just use the range constructor of e.g. vector. Furthermore, CheckRangeContains
is basically std:find then.

[Benedikt Meurer, 2014/12/16 06:10:25]

Ok, I see the reason to have this class in here, but it should be (a) a real STL
compatible class and (b) not in zone-containers.h as it has nothing to with
Zone. I.e.

template <typename Iterator>
class iterator_range {
 public:
  typedef Iterator iterator;
  typedef Iterator const_iterator;
  typedef std::iterator_traits<Iterator>::difference_type difference_type;

  template <typename Iterator2>
  iterator_range(Iterator2 begin, Iterator2 end) : begin_(begin), end_(end) {}

  const_iterator begin() const { return begin_; }
  const_iterator end() const { return end_; }

 private:
  const_iterator begin_ const;
  const_iterator end_ const;
};

Not sure where to put it tho. Maybe introduce some stl-utils or stl-support
header.

[titzer, 2014/12/16 07:55:10]

Using base::iterator_range now.

+  typedef T* iterator;
+  iterator begin_;
+  iterator end_;
+  iterator begin() { return begin_; }
+  iterator end() { return end_; }
+};
+
+
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_ZONE_CONTAINERS_H_