Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6543)

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm

Issue 803963005: Fix WeakPtrFactory member in OneClickSigninBubbleControllerTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm
index db9eafbcb61a06dc1464012d25f575d2ed6006ed..dd1b20e820b8cd64cb9d68314b090d0073efae25 100644
--- a/chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm
@@ -25,10 +25,11 @@ using ::testing::_;
class OneClickSigninBubbleControllerTest : public CocoaProfileTest {
public:
OneClickSigninBubbleControllerTest()
- : weak_ptr_factory_(this),
- start_sync_callback_(
+ : weak_ptr_factory_(this) {
+ start_sync_callback_ =
base::Bind(&OneClickSigninBubbleControllerTest::OnStartSync,
- weak_ptr_factory_.GetWeakPtr())) {}
+ weak_ptr_factory_.GetWeakPtr());
+ }
virtual void SetUp() override {
CocoaProfileTest::SetUp();
@@ -52,11 +53,12 @@ class OneClickSigninBubbleControllerTest : public CocoaProfileTest {
MOCK_METHOD1(OnStartSync, void(OneClickSigninSyncStarter::StartSyncMode));
protected:
- base::WeakPtrFactory<OneClickSigninBubbleControllerTest> weak_ptr_factory_;
BrowserWindow::StartSyncCallback start_sync_callback_;
base::scoped_nsobject<OneClickSigninBubbleController> controller_;
private:
+ base::WeakPtrFactory<OneClickSigninBubbleControllerTest> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(OneClickSigninBubbleControllerTest);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698