Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 803963004: Roll DomDistillerJS (Closed)

Created:
5 years, 11 months ago by cjhopman
Modified:
5 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll DomDistillerJS Picked up changes: 56f7579 Rewrite SimilarSiblingContentExpansion 2fda06e Fix printing of logged non-ascii characters 8f4713b Only strip one stack frame from JS exceptions efa4dce Remove unnecessary indent from code generation. 6134342 Fix TerminatingBlocksFinderTest 1f237e8 Make TerminatingBlocksFinder use a RegExp 80a34cf Change LogUtil.LOG_BUILDER to a String 9b2cdb2 Move most tests from test/ to jstest/ 169cb83 Add JavaScript.parseFloat and parseInt 22cebe8 Change how TextBlock nodes are tracked 9be60c8 Add correct imports for generated JsTestEntryImpl 6b17bca Convert uses of emulated Pattern/Matcher to RegExp c6bbc1e Add StringUtil.countWords and simplify TextBlockBuilder 7e2865e Simplify TextBlockBuilder c73a770 Split the handling of TextNodes out of BHTMLCH 8fad736 Make test debugging more better 3e1e81e Handle equally scored candidate lead images. a7ec3c8 Make JsTestEntry report correct success result d2213f3 Remove unused TextBlock statistics 755df35 Add some more fancy gwt flags 6380f5c Add ElementAction that simplifies TagAction+labelStack 870b65e Move ignoring elements into FilteringDomVisitor. 48aaaa2 Use JUnit-style null assertions in OpenGraphProtocolParserTest 4ba963b querySelectorAll usage in parseMetaTags is covered in jstests 6bb3e26 Add DomDistillerJsTestCase 3f5efb3 Flesh out jstest environment ef708c4 Use bash in install-build-deps.sh 9ef7a04 Add protobuf and xvfb packages to build deps. 33b9a04 Implement rest of the Assert interface d75ad6b Correct function name 1d72a60 Scope repeated value for JSON converter. e482386 Fix install-build-deps.sh for missed package da40e84 Make jstests not fail the build 0d6b80e Add automated driver for jstests 92ae3ba Add better stack traces for jstests a97c624 Modular heuristics for images 3bf867e Add framework for running tests in Chrome cea631f Add .clang-format file to enable git cl format fc23a51 Make image source absolute. 486fd14 Use java 7 and closure compiler 0dbffc4 Fix TextDocumentConstruction expectations 05c76c0 Remove gwt-2.5.1 and gwt_exporter ed4df25 Roll gwt to 2.7.0 (from 2.5.1) 6dc14d3 Optimize SchemaOrgParser.parse for speed d7c6805 Optimize OpenGraphProtocolParser.parseMetaTags for speed 64df32e Add fine-grained speed profiling inside MarkupParser cd97d4f Remove a bunch of unused stuff bf5347c Refactor handling of labels and tagactions 03cbda8 Rewrite DomWalker.walk ee46df0 Create a simple reader mode extension BUG=431067, 435264, 435371, 440102, 440977 Committed: https://crrev.com/c077b472b6c1bf4a7118b8b07c830c76d412bdae Cr-Commit-Position: refs/heads/master@{#313600}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase + fix failure #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -586 lines) Patch
M components/dom_distiller/core/javascript/domdistiller.js View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/package/js/domdistiller.js View 1 chunk +186 lines, -561 lines 0 comments Download
M third_party/dom_distiller_js/package/proto_gen/third_party/dom_distiller_js/dom_distiller_json_converter.h View 4 chunks +30 lines, -22 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
cjhopman
hm... it's been awhile.
5 years, 11 months ago (2015-01-13 03:43:20 UTC) #2
nyquist
lgtm definitely. let's try to do this more often.
5 years, 11 months ago (2015-01-13 16:55:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803963004/1
5 years, 11 months ago (2015-01-13 16:55:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/24873) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/14344)
5 years, 11 months ago (2015-01-13 17:56:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803963004/40001
5 years, 11 months ago (2015-01-20 21:44:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37131)
5 years, 11 months ago (2015-01-20 21:53:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803963004/60001
5 years, 11 months ago (2015-01-20 22:30:14 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-20 22:31:41 UTC) #14
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/9edb8e0c4856aad4277f4bdb6889f1514c77cd8b Cr-Commit-Position: refs/heads/master@{#312288}
5 years, 11 months ago (2015-01-20 22:33:02 UTC) #15
cjhopman
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/844043004/ by cjhopman@chromium.org. ...
5 years, 11 months ago (2015-01-20 22:35:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803963004/60001
5 years, 11 months ago (2015-01-21 00:27:14 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/112690) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/96625) Try ...
5 years, 11 months ago (2015-01-21 04:01:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803963004/60001
5 years, 10 months ago (2015-01-28 21:59:50 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-28 22:54:27 UTC) #23
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 22:57:33 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c077b472b6c1bf4a7118b8b07c830c76d412bdae
Cr-Commit-Position: refs/heads/master@{#313600}

Powered by Google App Engine
This is Rietveld 408576698