Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 803933003: IDL: various adjustments to match Web IDL specification better (Closed)

Created:
6 years ago by Jens Widell
Modified:
6 years ago
Reviewers:
haraken, noelallen1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IDL: various adjustments to match Web IDL specification better Notably adds support for maplike<type, type>, setlike<type>, iterable<type> and legacyiterable<type> declarations. Also changes some interface member grammar productions around a bit, and drops the deprecated Attribute production, which Blink's parser no longer references. Committed: https://crrev.com/9016ef32769c396deb32c17dc5f3ff4a6d8acdd4 Cr-Commit-Position: refs/heads/master@{#308584}

Patch Set 1 #

Patch Set 2 : #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -48 lines) Patch
M tools/idl_parser/idl_lexer.py View 2 chunks +6 lines, -1 line 0 comments Download
M tools/idl_parser/idl_parser.py View 6 chunks +83 lines, -46 lines 5 comments Download
M tools/idl_parser/idl_ppapi_parser.py View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/idl_parser/test_lexer/keywords.in View 1 chunk +11 lines, -1 line 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 1 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jens Widell
PTAL There are no (relevant) changes in parser's output. Blink's IDL compiler is unaffected. https://codereview.chromium.org/803933003/diff/20001/tools/idl_parser/idl_parser.py ...
6 years ago (2014-12-15 11:35:16 UTC) #2
haraken
LGTM https://codereview.chromium.org/803933003/diff/20001/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/803933003/diff/20001/tools/idl_parser/idl_parser.py#newcode528 tools/idl_parser/idl_parser.py:528: p[0] = p[1] p[0] = self.BuildTrue('REQUIRED') ? https://codereview.chromium.org/803933003/diff/20001/tools/idl_parser/idl_parser.py#newcode671 ...
6 years ago (2014-12-15 15:11:13 UTC) #3
Jens Widell
Thanks for review! https://codereview.chromium.org/803933003/diff/20001/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/803933003/diff/20001/tools/idl_parser/idl_parser.py#newcode528 tools/idl_parser/idl_parser.py:528: p[0] = p[1] On 2014/12/15 15:11:13, ...
6 years ago (2014-12-15 15:30:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803933003/20001
6 years ago (2014-12-16 15:02:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-16 15:05:20 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-16 15:06:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9016ef32769c396deb32c17dc5f3ff4a6d8acdd4
Cr-Commit-Position: refs/heads/master@{#308584}

Powered by Google App Engine
This is Rietveld 408576698