Remove SkCanvas::isDrawingToLayer

Remove SkCanvas::isDrawingToLayer

BUG=3245
Committed: https://skia.googlesource.com/skia/+/3fcc125c776c837aa858598ce385f5c6f8f01795

[Justin Novosad, 2014-12-15 17:16:53]

junov@chromium.org changed reviewers:
+ reed@google.com

[Justin Novosad, 2014-12-15 17:16:53]

PTAL

[mtklein, 2014-12-15 17:21:03]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-12-15 17:21:03]

https://codereview.chromium.org/803913005/diff/1/src/core/SkRecorder.cpp
File src/core/SkRecorder.cpp (left):

https://codereview.chromium.org/803913005/diff/1/src/core/SkRecorder.cpp#oldc...
src/core/SkRecorder.cpp:347: return fSaveLayerCount > 0;
Mind removing fSaveLayerCount and fSaveIsSaveLayer entirely?

[Justin Novosad, 2014-12-15 17:27:47]

On 2014/12/15 17:21:03, mtklein wrote:
> Mind removing fSaveLayerCount and fSaveIsSaveLayer entirely?

Done

[mtklein, 2014-12-15 17:33:34]

Duh, I should have looked harder at the other files last time.  I think we've
got three more of the same deal.

https://codereview.chromium.org/803913005/diff/20001/src/core/SkCanvas.cpp
File src/core/SkCanvas.cpp (left):

https://codereview.chromium.org/803913005/diff/20001/src/core/SkCanvas.cpp#ol...
src/core/SkCanvas.cpp:1050: return fSaveLayerCount > 0;
Looks like we don't need fSaveLayerCount anymore?

https://codereview.chromium.org/803913005/diff/20001/src/core/SkPictureRecord...
File src/core/SkPictureRecord.cpp (left):

https://codereview.chromium.org/803913005/diff/20001/src/core/SkPictureRecord...
src/core/SkPictureRecord.cpp:191: return fFirstSavedLayerIndex !=
kNoSavedLayerIndex;
Also clean up fFirstSaveLayerIndex / kNoSavedLayerIndex here?

https://codereview.chromium.org/803913005/diff/20001/src/pipe/SkGPipeWrite.cpp
File src/pipe/SkGPipeWrite.cpp (left):

https://codereview.chromium.org/803913005/diff/20001/src/pipe/SkGPipeWrite.cp...
src/pipe/SkGPipeWrite.cpp:582: return kNoSaveLayer != fFirstSaveLayerStackLevel;
Also clean up fFirstSaveLayerStackLevel / kNoSaveLayer here?

[reed1, 2014-12-15 18:05:30]

https://codereview.chromium.org/803913005/diff/1/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/803913005/diff/1/include/core/SkCanvas.h#newc...
include/core/SkCanvas.h:1248: int         fSaveLayerCount;    // number of
successful saveLayer calls
I think you can remove fSaveLayerCount...

[Justin Novosad, 2014-12-15 18:39:18]

On 2014/12/15 17:33:34, mtklein wrote:
> Duh, I should have looked harder at the other files last time.  I think we've
> got three more of the same deal.

Duh, I should have looked harder ;-)

[Justin Novosad, 2014-12-15 18:59:29]

New Patch

[reed1, 2014-12-15 19:03:38]

looks yummy to me
lgtm

[mtklein, 2014-12-15 19:05:25]

lgtm too

https://codereview.chromium.org/803913005/diff/40001/src/utils/SkDeferredCanv...
File src/utils/SkDeferredCanvas.cpp (right):

https://codereview.chromium.org/803913005/diff/40001/src/utils/SkDeferredCanv...
src/utils/SkDeferredCanvas.cpp:691: if (fFirstSaveLayerIndex ==
kNoSaveLayerIndex) {
It was neat to learn this doesn't need a stack, huh?  I hadn't realized it
myself until I saw all the code we were deleting.

[Justin Novosad, 2014-12-15 19:06:10]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2014-12-15 19:06:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803913005/40001

[commit-bot: I haz the power, 2014-12-15 19:14:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-15 19:14:55]

Try jobs failed on following builders:
  Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

[Justin Novosad, 2014-12-15 19:22:29]

On 2014/12/15 19:14:55, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia
>
(http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x...)

Oops fIsDrawingToLayer was left uninitialized in SkDeferredDevice::init.

[Justin Novosad, 2014-12-15 19:23:23]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2014-12-15 19:24:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/803913005/60001

[commit-bot: I haz the power, 2014-12-15 19:34:11]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3fcc125c776c837aa858598ce385f5c6f8f01795