Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

Issue 803913003: fix named constructor completion (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
index 7191f4ee87b7c84ed583774594254f9d8421fbbb..e2a229bdbd5caace1b9f335ef901f6adf921c885 100644
--- a/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/invocation_computer.dart
@@ -80,6 +80,23 @@ class _InvocationAstVisitor extends GeneralizingAstVisitor<SuggestionBuilder> {
_InvocationAstVisitor(this.request);
@override
+ visitConstructorName(ConstructorName node) {
+ // some PrefixedIdentifier nodes are transformed into
+ // ConstructorName nodes during the resolution process.
+ Token period = node.period;
+ if (period != null && request.offset > period.offset) {
+ TypeName type = node.type;
+ if (type != null) {
+ SimpleIdentifier prefix = type.name;
+ if (prefix != null) {
+ return new _PrefixedIdentifierSuggestionBuilder(request);
+ }
+ }
+ }
+ return null;
+ }
+
+ @override
SuggestionBuilder visitMethodInvocation(MethodInvocation node) {
Token period = node.period;
if (period == null || period.offset < request.offset) {
@@ -98,7 +115,7 @@ class _InvocationAstVisitor extends GeneralizingAstVisitor<SuggestionBuilder> {
// some PrefixedIdentifier nodes are transformed into
// ConstructorName nodes during the resolution process.
Token period = node.period;
- if (request.offset > period.offset) {
+ if (period != null && request.offset > period.offset) {
SimpleIdentifier prefix = node.prefix;
if (prefix != null) {
return new _PrefixedIdentifierSuggestionBuilder(request);

Powered by Google App Engine
This is Rietveld 408576698