pkg/analysis_server/lib/src/services/completion/imported_computer.dart - Issue 803913003: fix named constructor completion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

Issue 803913003: fix named constructor completion (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/invocation_computer.dart » ('j') | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/imported_computer.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

index 5b0d947e20b52a561e591de59c4d438abd18dbd0..51d58249d7895fce76efe712641468802827f643 100644

--- a/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

+++ b/pkg/analysis_server/lib/src/services/completion/imported_computer.dart

@@ -167,7 +167,7 @@ class _ImportedAstVisitor extends

// Make suggestions for the prefix, but not for the selector

// InvocationComputer makes selector suggestions

Token period = node.period;

- if (period != null && request.offset <= period.offset) {

+ if (period == null || request.offset <= period.offset) {

return new _ImportedSuggestionBuilder(request, excludeVoidReturn: true);

}

return null;