ContentBrowserSanityChecker

content/browser/frame_host/render_frame_host_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/cross_site_transferring_request.h"
@@ skipping 219 matching lines @@
     return favicon_received_;
   }
 
  private:
   bool plugin_crashed_;
   bool favicon_received_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginFaviconMessageObserver);
 };
 
-// Ensures that RenderFrameDeleted and RenderFrameCreated are called in a
-// consistent manner.
-class FrameLifetimeConsistencyChecker : public WebContentsObserver {
- public:
-  explicit FrameLifetimeConsistencyChecker(WebContentsImpl* web_contents)
-      : WebContentsObserver(web_contents) {
-    RenderViewCreated(web_contents->GetRenderViewHost());
-    RenderFrameCreated(web_contents->GetMainFrame());
-  }
-
-  void RenderFrameCreated(RenderFrameHost* render_frame_host) override {
-    std::pair<int, int> routing_pair =
-        std::make_pair(render_frame_host->GetProcess()->GetID(),
-                       render_frame_host->GetRoutingID());
-    bool was_live_already = !live_routes_.insert(routing_pair).second;
-    bool was_used_before = deleted_routes_.count(routing_pair) != 0;
-
-    if (was_live_already) {
-      FAIL() << "RenderFrameCreated called more than once for routing pair: "
-             << Format(render_frame_host);
-    } else if (was_used_before) {
-      FAIL() << "RenderFrameCreated called for routing pair "
-             << Format(render_frame_host) << " that was previously deleted.";
-    }
-  }
-
-  void RenderFrameDeleted(RenderFrameHost* render_frame_host) override {
-    std::pair<int, int> routing_pair =
-        std::make_pair(render_frame_host->GetProcess()->GetID(),
-                       render_frame_host->GetRoutingID());
-    bool was_live = live_routes_.erase(routing_pair);
-    bool was_dead_already = !deleted_routes_.insert(routing_pair).second;
-
-    if (was_dead_already) {
-      FAIL() << "RenderFrameDeleted called more than once for routing pair "
-             << Format(render_frame_host);
-    } else if (!was_live) {
-      FAIL() << "RenderFrameDeleted called for routing pair "
-             << Format(render_frame_host)
-             << " for which RenderFrameCreated was never called";
-    }
-  }
-
- private:
-  std::string Format(RenderFrameHost* render_frame_host) {
-    return base::StringPrintf(
-        "(%d, %d -> %s )",
-        render_frame_host->GetProcess()->GetID(),
-        render_frame_host->GetRoutingID(),
-        render_frame_host->GetSiteInstance()->GetSiteURL().spec().c_str());
-  }
-  std::set<std::pair<int, int> > live_routes_;
-  std::set<std::pair<int, int> > deleted_routes_;
-};
-
 }  // namespace
 
-class RenderFrameHostManagerTest
-    : public RenderViewHostImplTestHarness {
+class RenderFrameHostManagerTest : public RenderViewHostImplTestHarness {
  public:
   void SetUp() override {
     RenderViewHostImplTestHarness::SetUp();
     WebUIControllerFactory::RegisterFactory(&factory_);
-    lifetime_checker_.reset(new FrameLifetimeConsistencyChecker(contents()));
   }
 
   void TearDown() override {
-    lifetime_checker_.reset();
     RenderViewHostImplTestHarness::TearDown();
     WebUIControllerFactory::UnregisterFactoryForTesting(&factory_);
   }
 
   void set_should_create_webui(bool should_create_webui) {
     factory_.set_should_create_webui(should_create_webui);
   }
 
   void NavigateActiveAndCommit(const GURL& url) {
     // Note: we navigate the active RenderFrameHost because previous navigations
@@ skipping 100 matching lines @@
 
     dest_rfh->SendNavigate(101, kDestUrl);
     ntp_rfh->OnSwappedOut();
 
     EXPECT_TRUE(ntp_rfh->is_swapped_out());
     return ntp_rfh;
   }
 
  private:
   RenderFrameHostManagerTestWebUIControllerFactory factory_;
-  scoped_ptr<FrameLifetimeConsistencyChecker> lifetime_checker_;
 };
 
 // Tests that when you navigate from a chrome:// url to another page, and
 // then do that same thing in another tab, that the two resulting pages have
 // different SiteInstances, BrowsingInstances, and RenderProcessHosts. This is
 // a regression test for bug 9364.
 TEST_F(RenderFrameHostManagerTest, NewTabPageProcesses) {
   set_should_create_webui(true);
   const GURL kChromeUrl("chrome://foo");
   const GURL kDestUrl("http://www.google.com/");
@@ skipping 1463 matching lines @@
 #if 0
   // TODO(nick): Currently a proxy to the removed frame lingers in the parent.
   // Enable this assert below once the proxies to the subframe are correctly
   // cleaned up after detach.
   ASSERT_TRUE(site_instance->HasOneRef())
       << "This SiteInstance should be destroyable now.";
 #endif
 }
 
 }  // namespace content