Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 803843004: Do not emit indexed header fields first in HpackEncoder. (Closed)

Created:
6 years ago by Bence
Modified:
6 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not emit indexed header fields first in HpackEncoder. In HpackEncoder, do not emit regular headers that can be found in the dynamic table before the ones that cannot in fear of evicting one that could have been indexed. Instead, go through the header fields "in order". Note that since HpackEncoder takes the header block as a map, order is still not guaranteed. In particular, different keys will be sorted alphabetically. However, this change guarantees order of headers with identical keys. Such headers are passed as "key: value0\0value1" to HpackEncoder, but sent as two separate header fields "key: value0" and "key: value1" on the wire. Before this CL, order could have got changed depending on which fields were in the dynamic table. This CL lands server side change 82356409 by bnc. BUG=443570 Committed: https://crrev.com/540eba1e09561a3ba2ff663e26607d7bfc1397b5 Cr-Commit-Position: refs/heads/master@{#309064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -29 lines) Patch
M net/spdy/hpack_encoder.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M net/spdy/hpack_encoder_test.cc View 3 chunks +17 lines, -16 lines 0 comments Download
M net/spdy/hpack_round_trip_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: I'd like to land this today so that it could be merged to 40 ...
6 years ago (2014-12-18 16:15:52 UTC) #2
Ryan Hamilton
lgtm
6 years ago (2014-12-18 19:13:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803843004/1
6 years ago (2014-12-18 19:16:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 20:13:52 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-18 20:14:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/540eba1e09561a3ba2ff663e26607d7bfc1397b5
Cr-Commit-Position: refs/heads/master@{#309064}

Powered by Google App Engine
This is Rietveld 408576698