Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 80383008: Add checkstyle dependency to install-build-deps-android.sh (Closed)

Created:
7 years, 1 month ago by aurimas (slooooooooow)
Modified:
7 years, 1 month ago
Reviewers:
Yaron, Isaac (away)
CC:
chromium-reviews
Visibility:
Public.

Description

Add checkstyle dependency to install-build-deps-android.sh Add checkstyle to deps to unblock adding java checkstyle presubmit step. BUG=320711 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236781

Patch Set 1 #

Patch Set 2 : Moved to android specific file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
build/install-build-deps-android.sh View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
aurimas (slooooooooow)
Hey Yaron, Please take a look at this change. Thanks, Aurimas
7 years, 1 month ago (2013-11-22 02:38:54 UTC) #1
Yaron
+Isaac why not install-build-deps-android.sh ?
7 years, 1 month ago (2013-11-22 02:59:28 UTC) #2
aurimas (slooooooooow)
On 2013/11/22 02:59:28, Yaron wrote: > +Isaac > > why not install-build-deps-android.sh ? Done
7 years, 1 month ago (2013-11-22 03:15:52 UTC) #3
Yaron
lgtm should also have a psa. You can start w/ internal for now since that's ...
7 years, 1 month ago (2013-11-22 03:17:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/80383008/50001
7 years, 1 month ago (2013-11-22 16:51:28 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 16:51:45 UTC) #6
Message was sent while issue was closed.
Change committed as 236781

Powered by Google App Engine
This is Rietveld 408576698