Cast: Forcing codec initialization on a designated thread

Cast:Forcing VP8 codec initialization on a designated thread. 

Makes sure that all interaction with the video decoder is done on the VIDEO_DECODER thread.
Logging which was removed here, will be added in a follow  up cl.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238535

[mikhal, 2013-11-21 18:02:50]

Please review,

-Mikhal

[pwestin, 2013-11-21 19:10:41]

Added feedback

https://chromiumcodereview.appspot.com/80383006/diff/30001/media/cast/video_r...
File media/cast/video_receiver/codecs/vp8/vp8_decoder.h (right):

https://chromiumcodereview.appspot.com/80383006/diff/30001/media/cast/video_r...
media/cast/video_receiver/codecs/vp8/vp8_decoder.h:24:
Vp8Decoder(scoped_refptr<CastEnvironment> cast_environment);
should be explicit

https://chromiumcodereview.appspot.com/80383006/diff/30001/media/cast/video_r...
File media/cast/video_receiver/video_receiver.cc (right):

https://chromiumcodereview.appspot.com/80383006/diff/30001/media/cast/video_r...
media/cast/video_receiver/video_receiver.cc:151: void
VideoReceiver::InitDecoder() {
instead of having this code here; why not post the task in the constructor of
the codec ?

[mikhal, 2013-11-21 19:27:00]

PTAL

https://chromiumcodereview.appspot.com/80383006/diff/30001/media/cast/video_r...
File media/cast/video_receiver/codecs/vp8/vp8_decoder.h (right):

https://chromiumcodereview.appspot.com/80383006/diff/30001/media/cast/video_r...
media/cast/video_receiver/codecs/vp8/vp8_decoder.h:24:
Vp8Decoder(scoped_refptr<CastEnvironment> cast_environment);
On 2013/11/21 19:10:42, pwestin wrote:
> should be explicit 

Done.

https://chromiumcodereview.appspot.com/80383006/diff/30001/media/cast/video_r...
File media/cast/video_receiver/video_receiver.cc (right):

https://chromiumcodereview.appspot.com/80383006/diff/30001/media/cast/video_r...
media/cast/video_receiver/video_receiver.cc:151: void
VideoReceiver::InitDecoder() {
Had th same thought, but wasn't sure what's better. Will do now. 
On 2013/11/21 19:10:42, pwestin wrote:
> instead of having this code here; why not post the task in the constructor of
> the codec ?

[pwestin, 2013-11-21 21:45:37]

Change subject line to start with "Cast:"

Move PostTask into VideoDecoder from VideoEncoder

https://codereview.chromium.org/80383006/diff/20008/media/cast/video_receiver...
File media/cast/video_receiver/video_receiver.cc (right):

https://codereview.chromium.org/80383006/diff/20008/media/cast/video_receiver...
media/cast/video_receiver/video_receiver.cc:127:
cast_environment_->PostTask(CastEnvironment::VIDEO_DECODER, FROM_HERE,
we can move it all the way into the video_decoder; since it also have access to
the cast_environment.

[mikhal, 2013-11-22 22:02:41]

PTAL

https://chromiumcodereview.appspot.com/80383006/diff/20008/media/cast/video_r...
File media/cast/video_receiver/video_receiver.cc (right):

https://chromiumcodereview.appspot.com/80383006/diff/20008/media/cast/video_r...
media/cast/video_receiver/video_receiver.cc:127:
cast_environment_->PostTask(CastEnvironment::VIDEO_DECODER, FROM_HERE,
On 2013/11/21 21:45:38, pwestin wrote:
> we can move it all the way into the video_decoder; since it also have access
to
> the cast_environment. 

Done.

[mikhal1, 2013-12-03 16:58:15]

ping

[pwestin, 2013-12-03 18:57:43]

lgtm

[commit-bot: I haz the power, 2013-12-03 19:00:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhal@google.com/80383006/550001

[commit-bot: I haz the power, 2013-12-03 19:00:18]

Failed to apply patch for media/cast/video_receiver/codecs/vp8/vp8_decoder.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file media/cast/video_receiver/codecs/vp8/vp8_decoder.cc
  Hunk #1 succeeded at 19 with fuzz 2 (offset 7 lines).
  Hunk #2 succeeded at 43 (offset 7 lines).
  Hunk #3 FAILED at 87.
  1 out of 3 hunks FAILED -- saving rejects to file
media/cast/video_receiver/codecs/vp8/vp8_decoder.cc.rej

Patch:       media/cast/video_receiver/codecs/vp8/vp8_decoder.cc
Index: media/cast/video_receiver/codecs/vp8/vp8_decoder.cc
diff --git a/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc
b/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc
index
84d4fa9d5588ff18dead29733561de17e37e038e..015d49fb1ab0cf15d28ae261d7a76df79c8a1562
100644
--- a/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc
+++ b/media/cast/video_receiver/codecs/vp8/vp8_decoder.cc
@@ -12,18 +12,20 @@
 namespace media {
 namespace cast {
 
-Vp8Decoder::Vp8Decoder(int number_of_cores,
-                       scoped_refptr<CastEnvironment> cast_environment)
+Vp8Decoder::Vp8Decoder(scoped_refptr<CastEnvironment> cast_environment)
     : decoder_(new vpx_dec_ctx_t()),
       cast_environment_(cast_environment) {
-  InitDecode(number_of_cores);
+  // Make sure that we initialize the decoder from the correct thread.
+  cast_environment_->PostTask(CastEnvironment::VIDEO_DECODER, FROM_HERE,
+        base::Bind(&Vp8Decoder::InitDecoder, base::Unretained(this)));
 }
 
 Vp8Decoder::~Vp8Decoder() {}
 
-void Vp8Decoder::InitDecode(int number_of_cores) {
-  vpx_codec_dec_cfg_t  cfg;
-  cfg.threads = number_of_cores;
+void Vp8Decoder::InitDecoder() {
+  vpx_codec_dec_cfg_t cfg;
+  // Initializing to use one core.
+  cfg.threads = 1;
   vpx_codec_flags_t flags = VPX_CODEC_USE_POSTPROC;
 
   if (vpx_codec_dec_init(decoder_.get(), vpx_codec_vp8_dx(), &cfg, flags)) {
@@ -34,6 +36,7 @@ void Vp8Decoder::InitDecode(int number_of_cores) {
 bool Vp8Decoder::Decode(const EncodedVideoFrame* encoded_frame,
                         const base::TimeTicks render_time,
                         const VideoFrameDecodedCallback& frame_decoded_cb) {
+  DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::VIDEO_DECODER));
   const int frame_id_int = static_cast<int>(encoded_frame->frame_id);
   VLOG(1) << "VP8 decode frame:" << frame_id_int
           << " sized:" << encoded_frame->data.size();
@@ -84,10 +87,7 @@ bool Vp8Decoder::Decode(const EncodedVideoFrame*
encoded_frame,
   memcpy(decoded_frame->v_plane.data, img->planes[VPX_PLANE_V],
          decoded_frame->v_plane.length);
 
-  cast_environment_->Logging()->InsertFrameEvent(kVideoFrameDecoded,
-      kFrameIdUnknown, encoded_frame->frame_id);
   VLOG(1) << "Decoded frame " << frame_id_int;
-
   // Frame decoded - return frame to the user via callback.
   cast_environment_->PostTask(CastEnvironment::MAIN, FROM_HERE,
       base::Bind(frame_decoded_cb, base::Passed(&decoded_frame), render_time));

[commit-bot: I haz the power, 2013-12-03 20:59:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhal@google.com/80383006/640001

[commit-bot: I haz the power, 2013-12-03 23:38:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhal@google.com/80383006/640001

[commit-bot: I haz the power, 2013-12-04 03:02:04]

Change committed as 238535