Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 803763002: remove some pre vs2013 code (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

remove some pre vs2013 code We only support building for windows with Visual Studio 2013 Update 4 now, so let's remove dead code that is only used for older Visual Studio versions. BUG=442035 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187108

Patch Set 1 #

Patch Set 2 : fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M Source/wtf/MathExtras.h View 1 3 chunks +0 lines, -69 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mostyn Bramley-Moore
@tkent: does this dead code removal look OK to you?
6 years ago (2014-12-13 06:59:03 UTC) #2
tkent
lgtm
6 years ago (2014-12-15 01:34:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/803763002/20001
6 years ago (2014-12-15 01:35:35 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 03:15:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187108

Powered by Google App Engine
This is Rietveld 408576698